Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tests/presubmit_unittest.py

Issue 2070493002: Expose fnmatch in presubmit's input_api. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « presubmit_support.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/presubmit_unittest.py
diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py
index 7b131029346d90512525cba59ba0bc241289b1a0..2863c1446cebbd076238c826e8a12e11dd2d8b20 100755
--- a/tests/presubmit_unittest.py
+++ b/tests/presubmit_unittest.py
@@ -1190,17 +1190,58 @@ class InputApiUnittest(PresubmitTestsBase):
def testMembersChanged(self):
self.mox.ReplayAll()
members = [
- 'AbsoluteLocalPaths', 'AffectedFiles', 'AffectedSourceFiles',
- 'AffectedTextFiles', 'DEFAULT_BLACK_LIST', 'DEFAULT_WHITE_LIST',
- 'DepotToLocalPath', 'FilterSourceFile', 'LocalPaths', 'LocalToDepotPath',
- 'Command', 'RunTests', 'PresubmitLocalPath', 'ReadFile',
- 'RightHandSideLines', 'ServerPaths', 'basename', 'cPickle', 'cpplint',
- 'cStringIO', 'canned_checks', 'change', 'cpu_count', 'environ', 'glob',
- 'host_url', 'is_committing', 'json', 'logging', 'marshal', 'os_listdir',
- 'os_walk', 'os_path', 'os_stat', 'owners_db', 'pickle', 'platform',
- 'python_executable', 're', 'rietveld', 'subprocess', 'tbr', 'tempfile',
- 'time', 'traceback', 'unittest', 'urllib2', 'version', 'verbose',
- 'dry_run', 'gerrit',
+ 'AbsoluteLocalPaths',
+ 'AffectedFiles',
+ 'AffectedSourceFiles',
+ 'AffectedTextFiles',
+ 'DEFAULT_BLACK_LIST',
+ 'DEFAULT_WHITE_LIST',
+ 'DepotToLocalPath',
+ 'FilterSourceFile',
+ 'LocalPaths',
+ 'LocalToDepotPath',
+ 'Command',
+ 'RunTests',
+ 'PresubmitLocalPath',
+ 'ReadFile',
+ 'RightHandSideLines',
+ 'ServerPaths',
+ 'basename',
+ 'cPickle',
+ 'cpplint',
+ 'cStringIO',
+ 'canned_checks',
+ 'change',
+ 'cpu_count',
+ 'environ',
+ 'fnmatch',
+ 'glob',
+ 'host_url',
+ 'is_committing',
+ 'json',
+ 'logging',
+ 'marshal',
+ 'os_listdir',
+ 'os_walk',
+ 'os_path',
+ 'os_stat',
+ 'owners_db',
+ 'pickle',
+ 'platform',
+ 'python_executable',
+ 're',
+ 'rietveld',
+ 'subprocess',
+ 'tbr',
+ 'tempfile',
+ 'time',
+ 'traceback',
+ 'unittest',
+ 'urllib2',
+ 'version',
+ 'verbose',
+ 'dry_run',
+ 'gerrit',
]
# If this test fails, you should add the relevant test.
self.compareMembers(
@@ -2735,7 +2776,7 @@ class CannedChecksUnittest(PresubmitTestsBase):
"sender": "ben@example.com", "text": "foo", "approval": False,
},
],
- "reviewers":[],
+ "reviewers": [],
}
self.AssertOwnersWorks(
approvers=set(),
« no previous file with comments | « presubmit_support.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698