Use scope defined in Web Manifest when adding page to homescreen

Use scope defined in Web Manifest when adding page to homescreen

BUG=619739
Committed: https://crrev.com/6bdfbe1bb993034cdb3d2fc846730e572176fde2
Cr-Commit-Position: refs/heads/master@{#404273}

[pkotwicz, 2016-06-15 03:02:47]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2016-06-15 03:03:22]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2016-06-15 03:03:23]

Xi can you please take a look? This CL depends on
https://codereview.chromium.org/2063003003/

[Xi Han, 2016-06-16 13:44:29]

lgtm

[pkotwicz, 2016-07-06 01:38:01]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org, mlamouri@chromium.org

[pkotwicz, 2016-07-06 01:38:01]

mlamouri@ and dominickn@ can you please take a look?

[dominickn, 2016-07-06 12:29:33]

Description was changed from

==========
Use scope defined in Web Manifest when adding page to homescreen

BUG=619739
==========

to

==========
Use scope defined in Web Manifest when adding page to homescreen

BUG=619739
==========

[dominickn, 2016-07-06 12:33:18]

On 2016/07/06 01:38:01, pkotwicz wrote:
> mlamouri@ and dominickn@ can you please take a look?

Do we want to resolve crbug.com/624563 before implementing this? Otherwise lgtm.

Note for myself: addShortcut is getting a nasty number of arguments now, it may
be worth investigating whether we can marshall them more cleanly.

+cc sammc as this will impact crrev.com/1913043002 (converting manifest manager
messages to Mojo)

[pkotwicz, 2016-07-06 14:52:07]

mlamouri@ can you please take a look?

This CL is separate from crbug.com/624563

[mlamouri (slow - plz ping), 2016-07-07 10:22:04]

lgtm

[pkotwicz, 2016-07-07 14:55:58]

pkotwicz@chromium.org changed reviewers:
+ sievers@chromium.org, yfriedman@chromium.org

[pkotwicz, 2016-07-07 14:55:59]

sievers@ for content/ OWNERS
yfriedman@ for chrome/browser/android OWNERS

[no sievers, 2016-07-07 17:19:50]

On 2016/07/07 14:55:59, pkotwicz wrote:
> sievers@ for content/ OWNERS
> yfriedman@ for chrome/browser/android OWNERS

lgtm

[Yaron, 2016-07-07 17:42:28]

lgtm

[pkotwicz, 2016-07-07 17:43:41]

pkotwicz@chromium.org changed reviewers:
+ rsesek@chromium.org

[pkotwicz, 2016-07-07 17:43:42]

rsesek@ for content/common/manifest_manager_messages.h

[Robert Sesek, 2016-07-07 18:55:51]

lgtm

[pkotwicz, 2016-07-07 20:48:57]

Patchset #2 (id:40001) has been deleted

[pkotwicz, 2016-07-07 20:49:47]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-07-07 20:49:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org, mlamouri@chromium.org, yfriedman@chromium.org,
sievers@chromium.org, rsesek@chromium.org, hanxi@chromium.org
Link to the patchset: https://codereview.chromium.org/2070433002/#ps60001
(title: "Merge branch 'master' into webapk_scope")

[commit-bot: I haz the power, 2016-07-07 20:50:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 22:52:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 22:52:19]

Try jobs failed on following builders:
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)

[pkotwicz, 2016-07-08 00:06:54]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-07-08 00:07:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 00:27:54]

Description was changed from

==========
Use scope defined in Web Manifest when adding page to homescreen

BUG=619739
==========

to

==========
Use scope defined in Web Manifest when adding page to homescreen

BUG=619739
==========

[commit-bot: I haz the power, 2016-07-08 00:27:56]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-07-08 00:28:39]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 00:29:43]

Description was changed from

==========
Use scope defined in Web Manifest when adding page to homescreen

BUG=619739
==========

to

==========
Use scope defined in Web Manifest when adding page to homescreen

BUG=619739

Committed: https://crrev.com/6bdfbe1bb993034cdb3d2fc846730e572176fde2
Cr-Commit-Position: refs/heads/master@{#404273}
==========

[commit-bot: I haz the power, 2016-07-08 00:29:48]

Patchset 2 (id:??) landed as
https://crrev.com/6bdfbe1bb993034cdb3d2fc846730e572176fde2
Cr-Commit-Position: refs/heads/master@{#404273}