chrome/browser/android/shortcut_helper.cc - Issue 2070433002: Use scope defined in Web Manifest when adding page to homescreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/shortcut_helper.cc

Issue 2070433002: Use scope defined in Web Manifest when adding page to homescreen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_scope Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java ('k') | chrome/browser/android/shortcut_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/shortcut_helper.cc

diff --git a/chrome/browser/android/shortcut_helper.cc b/chrome/browser/android/shortcut_helper.cc

index e4769d98c6e7eda455c325684699a18b4f7067ed..3e1c122b2545f70ee8edbcf265162e77b27a149c 100644

--- a/chrome/browser/android/shortcut_helper.cc

+++ b/chrome/browser/android/shortcut_helper.cc

@@ -72,6 +72,8 @@ void ShortcutHelper::AddShortcutInBackgroundWithSkBitmap(

base::android::ConvertUTF8ToJavaString(env, webapp_id);

ScopedJavaLocalRef<jstring> java_url =

base::android::ConvertUTF8ToJavaString(env, info.url.spec());

+ ScopedJavaLocalRef<jstring> java_scope_url =

+ base::android::ConvertUTF8ToJavaString(env, info.scope.spec());

ScopedJavaLocalRef<jstring> java_user_title =

base::android::ConvertUTF16ToJavaString(env, info.user_title);

ScopedJavaLocalRef<jstring> java_name =

@@ -102,6 +104,7 @@ void ShortcutHelper::AddShortcutInBackgroundWithSkBitmap(

env,

java_webapp_id.obj(),

java_url.obj(),

+ java_scope_url.obj(),

java_user_title.obj(),

java_name.obj(),

java_short_name.obj(),

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java ('k') | chrome/browser/android/shortcut_info.h » ('j') | no next file with comments »