Use an explicit list of webkit-patch commands instead of using auto-discovery.

Use an explicit list of webkit-patch commands instead of using auto-discovery.

This is a followup to http://crrev.com/1950773002 and related CLs,
which removed remove imports from other __init__.py files; after this,
all of the __init__.py files in webkitpy are empty.

Before this CL, webkit-patch relies on all commands being imported (by
importing the package webkitpy.tool.commands) and then discovering all
subclasses of command using the magic method __subclasses__.

This CL makes it so that commands that are part of webkit-patch are
explicitly listed, and there is no class discovery.

BUG=598897
Committed: https://crrev.com/b5277f6feda049f0941928ae198ed8fed41e15a2
Cr-Commit-Position: refs/heads/master@{#400369}

[qyearsley, 2016-06-16 16:15:54]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-06-16 22:22:24]

lgtm

[qyearsley, 2016-06-17 04:36:03]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-06-17 04:36:04]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2070333003/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2016-06-17 04:36:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070333003/20001

[commit-bot: I haz the power, 2016-06-17 05:44:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-17 05:45:51]

Description was changed from

==========
Use an explicit list of webkit-patch commands instead of using auto-discovery.

This is a followup to http://crrev.com/1950773002 and related CLs,
which removed remove imports from other __init__.py files; after this,
all of the __init__.py files in webkitpy are empty.

Before this CL, webkit-patch relies on all commands being imported (by
importing the package webkitpy.tool.commands) and then discovering all
subclasses of command using the magic method __subclasses__.

This CL makes it so that commands that are part of webkit-patch are
explicitly listed, and there is no class discovery.

BUG=598897
==========

to

==========
Use an explicit list of webkit-patch commands instead of using auto-discovery.

This is a followup to http://crrev.com/1950773002 and related CLs,
which removed remove imports from other __init__.py files; after this,
all of the __init__.py files in webkitpy are empty.

Before this CL, webkit-patch relies on all commands being imported (by
importing the package webkitpy.tool.commands) and then discovering all
subclasses of command using the magic method __subclasses__.

This CL makes it so that commands that are part of webkit-patch are
explicitly listed, and there is no class discovery.

BUG=598897

Committed: https://crrev.com/b5277f6feda049f0941928ae198ed8fed41e15a2
Cr-Commit-Position: refs/heads/master@{#400369}
==========

[commit-bot: I haz the power, 2016-06-17 05:45:52]

Patchset 2 (id:??) landed as
https://crrev.com/b5277f6feda049f0941928ae198ed8fed41e15a2
Cr-Commit-Position: refs/heads/master@{#400369}

[Xianzhu, 2016-06-17 06:03:13]

This seems to break rebaseline-o-matic:
https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/...

[Xianzhu, 2016-06-17 06:16:39]

wangxianzhu@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[Xianzhu, 2016-06-17 06:16:40]

The CL needs modification to work. Would you mind if I revert it?

https://codereview.chromium.org/2070333003/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py (right):

https://codereview.chromium.org/2070333003/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py:66: self.commands
= [
This should be passed to the constructor of MultiCommandTool. With the current
code, the commands are not bound to tool.

[Xianzhu, 2016-06-17 06:17:32]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2075073002/ by wangxianzhu@chromium.org.

The reason for reverting is: Broke rebaseline-o-matic because commands are not
bound to tool..

[qyearsley, 2016-06-17 15:08:18]

On 2016/06/17 at 06:17:32, wangxianzhu wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2075073002/ by wangxianzhu@chromium.org.
> 
> The reason for reverting is: Broke rebaseline-o-matic because commands are not
bound to tool..

Ah, didn't catch this -- will make a reland CL with a patch to fix this.