third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool_unittest.py - Issue 2070333003: Use an explicit list of webkit-patch commands instead of using auto-discovery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool_unittest.py

Issue 2070333003: Use an explicit list of webkit-patch commands instead of using auto-discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool_unittest.py

index 10d9ede0d6ea0c4d32103d9dda2b00857f445367..9b003e431fa03583a34dd18997fee4fd20927aa5 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool_unittest.py

@@ -32,7 +32,7 @@ from optparse import make_option

from webkitpy.common.system.outputcapture import OutputCapture

from webkitpy.tool.multi_command_tool import MultiCommandTool

-from webkitpy.tool.commands import Command

+from webkitpy.tool.commands.command import Command

class TrivialCommand(Command):

@@ -85,8 +85,7 @@ class MultiCommandToolTest(unittest.TestCase):

self._assert_split(full_args, full_args_expected)

def test_command_by_name(self):

- # This also tests Command auto-discovery.

- tool = TrivialTool()

+ tool = TrivialTool(commands=[TrivialCommand(), UncommonCommand()])

self.assertEqual(tool.command_by_name("trivial").name, "trivial")

self.assertIsNone(tool.command_by_name("bar"))