content/public/common/drop_data.h - Issue 207013003: Mark drags starting in web content as tainted to avoid file path forgery

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/drop_data.h

Issue 207013003: Mark drags starting in web content as tainted to avoid file path forgery (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cleanup Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_view_host_impl.cc ('K') | « content/browser/web_contents/web_drag_source_gtk.cc ('k') | content/public/common/drop_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/drop_data.h

diff --git a/content/public/common/drop_data.h b/content/public/common/drop_data.h

index 74ad79ddd71d1c1d101917889d542de2c841cd1b..423be52f917eca05352b1f9e8652057bafe3dadf 100644

--- a/content/public/common/drop_data.h

+++ b/content/public/common/drop_data.h

@@ -35,6 +35,9 @@ struct CONTENT_EXPORT DropData {

DropData();

~DropData();

+ // Whether this drag originated from a renderer.

+ bool did_originate_from_renderer;

// User is dragging a link into the webview.

GURL url;

base::string16 url_title; // The title associated with |url|.

@@ -46,7 +49,9 @@ struct CONTENT_EXPORT DropData {

// a download.

blink::WebReferrerPolicy referrer_policy;

- // User is dropping one or more files on the webview.

+ // User is dropping one or more files on the webview. This field is only

+ // populated if the drag is not renderer tainted, as this allows File access

+ // from web content.

std::vector<FileInfo> filenames;

// Isolated filesystem ID for the files being dragged on the webview.