content/browser/renderer_host/render_view_host_impl.cc - Issue 207013003: Mark drags starting in web content as tainted to avoid file path forgery

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 207013003: Mark drags starting in web content as tainted to avoid file path forgery (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cleanup Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index d7b5686b9f8ec631b0b3de789ef6a6700c85fd1c..494f256ad755136a3d5c1ae1cc7fc4aaedf5e8a6 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -749,6 +749,9 @@ void RenderViewHostImpl::DragTargetDragEnter(

// and can't be interpreted as a capability.

DropData filtered_data(drop_data);

GetProcess()->FilterURL(true, &filtered_data.url);

+ if (drop_data.did_originate_from_renderer) {

Charlie Reis 2014/03/24 21:19:10 nit: No need for braces here.

+ filtered_data.filenames.clear();

+ }

// The filenames vector, on the other hand, does represent a capability to

// access the given files.

« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_view_aura.cc » ('j') | no next file with comments »