Quick View: Change file selection with arrow keys.

Quick View: Change file selection with arrow keys.

Also disable quick view if dialog type is not FULL_PAGE (e.g. download dialog).

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler

Committed: https://crrev.com/ef6fecbba090d954afe3efd69d7c50bbc8a46168
Cr-Commit-Position: refs/heads/master@{#399977}

[oka, 2016-06-15 16:01:23]

Description was changed from

==========
Quick View: Move with arrow keys.

BUG=2065403002
TEST=manually
==========

to

==========
Quick View: Move with arrow keys.

BUG=613465
TEST=manually
==========

[oka, 2016-06-15 16:01:23]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2016-06-15 16:29:03]

update

[oka, 2016-06-15 16:31:12]

Description was changed from

==========
Quick View: Move with arrow keys.

BUG=613465
TEST=manually
==========

to

==========
Quick View: Move with arrow keys.

Also disable quick view if dialog type is not FULL_PAGE (e.g. download dialog).

BUG=613465
TEST=manually
==========

[oka, 2016-06-15 16:31:29]

Description was changed from

==========
Quick View: Move with arrow keys.

Also disable quick view if dialog type is not FULL_PAGE (e.g. download dialog).

BUG=613465
TEST=manually
==========

to

==========
Quick View: Move with arrow keys.

Also disable quick view if dialog type is not FULL_PAGE (e.g. download dialog).

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler
==========

[oka, 2016-06-15 16:32:06]

PTAL

[oka, 2016-06-15 16:33:42]

Description was changed from

==========
Quick View: Move with arrow keys.

Also disable quick view if dialog type is not FULL_PAGE (e.g. download dialog).

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler
==========

to

==========
Quick View: Change　file selection with arrow keys.

Also disable quick view if dialog type is not FULL_PAGE (e.g. download dialog).

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler
==========

[oka, 2016-06-15 16:33:55]

Description was changed from

==========
Quick View: Change　file selection with arrow keys.

Also disable quick view if dialog type is not FULL_PAGE (e.g. download dialog).

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler
==========

to

==========
Quick View: Change file selection with arrow keys.

Also disable quick view if dialog type is not FULL_PAGE (e.g. download dialog).

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler
==========

[fukino, 2016-06-15 16:57:39]

lgtm with a nit

https://codereview.chromium.org/2070033002/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/2070033002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/file_manager.js:551: var
fileListSelectionModel = (/** @type {!cr.ui.ListSelectionModel} */ (
'(' before '/**' is not necessary.

[oka, 2016-06-15 18:18:39]

nit

[oka, 2016-06-15 18:18:53]

The CQ bit was checked by oka@chromium.org

[oka, 2016-06-15 18:18:54]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2070033002/#ps60001
(title: "nit")

[oka, 2016-06-15 18:19:09]

On 2016/06/15 16:57:39, fukino wrote:
> lgtm with a nit
> 
>
https://codereview.chromium.org/2070033002/diff/40001/ui/file_manager/file_ma...
> File ui/file_manager/file_manager/foreground/js/file_manager.js (right):
> 
>
https://codereview.chromium.org/2070033002/diff/40001/ui/file_manager/file_ma...
> ui/file_manager/file_manager/foreground/js/file_manager.js:551: var
> fileListSelectionModel = (/** @type {!cr.ui.ListSelectionModel} */ (
> '(' before '/**' is not necessary.

Done.

[commit-bot: I haz the power, 2016-06-15 18:19:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070033002/60001

[commit-bot: I haz the power, 2016-06-15 18:53:21]

Description was changed from

==========
Quick View: Change file selection with arrow keys.

Also disable quick view if dialog type is not FULL_PAGE (e.g. download dialog).

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler
==========

to

==========
Quick View: Change file selection with arrow keys.

Also disable quick view if dialog type is not FULL_PAGE (e.g. download dialog).

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler
==========

[commit-bot: I haz the power, 2016-06-15 18:53:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-15 18:55:14]

Description was changed from

==========
Quick View: Change file selection with arrow keys.

Also disable quick view if dialog type is not FULL_PAGE (e.g. download dialog).

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler
==========

to

==========
Quick View: Change file selection with arrow keys.

Also disable quick view if dialog type is not FULL_PAGE (e.g. download dialog).

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler

Committed: https://crrev.com/ef6fecbba090d954afe3efd69d7c50bbc8a46168
Cr-Commit-Position: refs/heads/master@{#399977}
==========

[commit-bot: I haz the power, 2016-06-15 18:55:15]

Patchset 4 (id:??) landed as
https://crrev.com/ef6fecbba090d954afe3efd69d7c50bbc8a46168
Cr-Commit-Position: refs/heads/master@{#399977}