Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 2070033002: Quick View: Change file selection with arrow keys. (Closed)

Created:
4 years, 6 months ago by oka
Modified:
4 years, 6 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Quick View: Change file selection with arrow keys. Also disable quick view if dialog type is not FULL_PAGE (e.g. download dialog). BUG=613465 TEST=manually third_party/closure_compiler/run_compiler Committed: https://crrev.com/ef6fecbba090d954afe3efd69d7c50bbc8a46168 Cr-Commit-Position: refs/heads/master@{#399977}

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : update #

Total comments: 1

Patch Set 4 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -22 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 2 3 2 chunks +16 lines, -12 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/quick_view_controller.js View 1 5 chunks +30 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
oka
update
4 years, 6 months ago (2016-06-15 16:29:03 UTC) #3
oka
PTAL
4 years, 6 months ago (2016-06-15 16:32:06 UTC) #6
fukino
lgtm with a nit https://codereview.chromium.org/2070033002/diff/40001/ui/file_manager/file_manager/foreground/js/file_manager.js File ui/file_manager/file_manager/foreground/js/file_manager.js (right): https://codereview.chromium.org/2070033002/diff/40001/ui/file_manager/file_manager/foreground/js/file_manager.js#newcode551 ui/file_manager/file_manager/foreground/js/file_manager.js:551: var fileListSelectionModel = (/** @type ...
4 years, 6 months ago (2016-06-15 16:57:39 UTC) #9
oka
nit
4 years, 6 months ago (2016-06-15 18:18:39 UTC) #10
oka
On 2016/06/15 16:57:39, fukino wrote: > lgtm with a nit > > https://codereview.chromium.org/2070033002/diff/40001/ui/file_manager/file_manager/foreground/js/file_manager.js > File ...
4 years, 6 months ago (2016-06-15 18:19:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070033002/60001
4 years, 6 months ago (2016-06-15 18:19:23 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-15 18:53:22 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 18:55:15 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ef6fecbba090d954afe3efd69d7c50bbc8a46168
Cr-Commit-Position: refs/heads/master@{#399977}

Powered by Google App Engine
This is Rietveld 408576698