Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2312)

Unified Diff: ui/file_manager/file_manager/foreground/js/file_manager.js

Issue 2070033002: Quick View: Change file selection with arrow keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/file_manager/file_manager/foreground/js/quick_view_controller.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/foreground/js/file_manager.js
diff --git a/ui/file_manager/file_manager/foreground/js/file_manager.js b/ui/file_manager/file_manager/foreground/js/file_manager.js
index ad93edc37601760e1453abc5f0e94976f1ec7d79..d5bbf39e0beae4a99f94b5587115367d1e21ddca 100644
--- a/ui/file_manager/file_manager/foreground/js/file_manager.js
+++ b/ui/file_manager/file_manager/foreground/js/file_manager.js
@@ -533,18 +533,6 @@ FileManager.prototype = /** @struct */ {
/**@private {!FilesQuickView} */
var quickView = /** @type {!FilesQuickView} */
(queryRequiredElement('#quick-view'));
- chrome.commandLinePrivate.hasSwitch(
- 'disable-files-quick-view', function(disabled) {
- if (!disabled) {
- this.quickViewController_ = new QuickViewController(
- quickView, assert(this.metadataModel_),
- assert(this.selectionHandler_), assert(this.ui_.listContainer),
- assert(this.quickViewModel_), assert(this.taskController_));
- this.metadataBoxController_ = new MetadataBoxController(
- this.metadataModel_, quickView.getFilesMetadataBox(), quickView,
- this.quickViewModel_);
- }
- }.bind(this));
if (this.dialogType === DialogType.FULL_PAGE) {
importer.importEnabled().then(
@@ -560,6 +548,22 @@ FileManager.prototype = /** @struct */ {
assert(this.tracker_));
}
}.bind(this));
+ var fileListSelectionModel = /** @type {!cr.ui.ListSelectionModel} */ (
+ this.directoryModel_.getFileListSelection());
+ chrome.commandLinePrivate.hasSwitch(
+ 'disable-files-quick-view', function(disabled) {
+ if (!disabled) {
+ this.quickViewController_ = new QuickViewController(
+ quickView, assert(this.metadataModel_),
+ assert(this.selectionHandler_),
+ assert(this.ui_.listContainer), assert(this.quickViewModel_),
+ assert(this.taskController_),
+ fileListSelectionModel);
+ this.metadataBoxController_ = new MetadataBoxController(
+ this.metadataModel_, quickView.getFilesMetadataBox(),
+ quickView, this.quickViewModel_);
+ }
+ }.bind(this));
}
assert(this.fileFilter_);
« no previous file with comments | « no previous file | ui/file_manager/file_manager/foreground/js/quick_view_controller.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698