Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 2070003002: V8: Let peek-gn use mb to reuse v8-side configs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium/api.py
diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py
index 8870c95734d03a42df0835dffb8883da586832bf..ea413cc92dd0046bcfebf615d881aea3da56d6d1 100644
--- a/scripts/slave/recipe_modules/chromium/api.py
+++ b/scripts/slave/recipe_modules/chromium/api.py
@@ -577,7 +577,7 @@ class ChromiumApi(recipe_api.RecipeApi):
def run_mb(self, mastername, buildername, use_goma=True,
mb_config_path=None, isolated_targets=None, name=None,
build_dir=None, android_version_code=None,
- android_version_name=None, gyp_script=None):
+ android_version_name=None, gyp_script=None, **kwargs_override):
mb_config_path = (mb_config_path or
self.m.path['checkout'].join('tools', 'mb',
'mb_config.pyl'))
@@ -642,6 +642,7 @@ class ChromiumApi(recipe_api.RecipeApi):
# Wrap 'runhooks' through 'cros chrome-sdk'
kwargs['wrapper'] = self.get_cros_chrome_sdk_wrapper(clean=True)
+ kwargs.update(kwargs_override)
Michael Achenbach 2016/06/15 14:44:37 Need this to pass ok_ret=any
tandrii(chromium) 2016/06/15 15:25:37 consider: s/kwargs/step_kwargs, and use normal **k
Michael Achenbach 2016/06/15 15:58:17 Done.
self.m.python(**kwargs)
# Comes after self.m.python so the log appears in the correct step result.
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/api.py » ('j') | scripts/slave/recipe_modules/v8/resources/patch_mb_config.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698