Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: scripts/slave/recipe_modules/v8/resources/patch_mb_config.py

Issue 2070003002: V8: Let peek-gn use mb to reuse v8-side configs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/v8/resources/patch_mb_config.py
diff --git a/scripts/slave/recipe_modules/v8/resources/patch_mb_config.py b/scripts/slave/recipe_modules/v8/resources/patch_mb_config.py
new file mode 100755
index 0000000000000000000000000000000000000000..59d40d1caff64b0f992be7ef725df3f607352481
--- /dev/null
+++ b/scripts/slave/recipe_modules/v8/resources/patch_mb_config.py
@@ -0,0 +1,15 @@
+#!/usr/bin/env python
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Script that makes an mb config use gn where it's supposed to use gyp.
+
+This is used to run gn on all gyp bots as an fyi step.
+"""
+
+import sys
+
+with open(sys.argv[1]) as f:
+ with open(sys.argv[2], 'w') as g:
+ g.write(f.read().replace('\'type\': \'gyp\'', '\'type\': \'gn\''))
Michael Achenbach 2016/06/15 14:44:37 Tested this locally with our mb_config.pyl file.
tandrii(chromium) 2016/06/15 15:25:37 imo, usage of "" is justfied here. But whatever.
Michael Achenbach 2016/06/15 15:58:17 ok done

Powered by Google App Engine
This is Rietveld 408576698