Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2069953003: [perf] Don't ignore dump and process counts in TBMv2 memory-infra benchmarks (Closed)

Created:
4 years, 6 months ago by petrcermak
Modified:
4 years, 6 months ago
Reviewers:
nednguyen, mythria, perezju
CC:
chromium-reviews, perezju
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[perf] Don't ignore dump and process counts in TBMv2 memory-infra benchmarks The existing code incorrectly filtered memory dump count totals because they end with '_count': memory:<browser>:all_processes:dump_count The filtering is only supposed to apply to statistics of numerics. BUG=617117 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/f52622ed991f0d5e269a1d99085edb115e58d267 Cr-Commit-Position: refs/heads/master@{#399932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/perf/benchmarks/memory_infra.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/v8.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
petrcermak
PTAL. Thanks, Petr
4 years, 6 months ago (2016-06-15 10:01:15 UTC) #3
perezju
lgtm
4 years, 6 months ago (2016-06-15 10:55:41 UTC) #4
mythria
Thanks Petr, lgtm.
4 years, 6 months ago (2016-06-15 11:22:54 UTC) #5
nednguyen
lgtm
4 years, 6 months ago (2016-06-15 12:35:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069953003/1
4 years, 6 months ago (2016-06-15 12:35:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/177805)
4 years, 6 months ago (2016-06-15 13:55:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069953003/1
4 years, 6 months ago (2016-06-15 14:20:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069953003/1
4 years, 6 months ago (2016-06-15 17:03:24 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 17:08:24 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 17:11:28 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f52622ed991f0d5e269a1d99085edb115e58d267
Cr-Commit-Position: refs/heads/master@{#399932}

Powered by Google App Engine
This is Rietveld 408576698