Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: tools/perf/benchmarks/memory_infra.py

Issue 2069953003: [perf] Don't ignore dump and process counts in TBMv2 memory-infra benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/perf/benchmarks/v8.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from core import perf_benchmark 7 from core import perf_benchmark
8 8
9 from telemetry import benchmark 9 from telemetry import benchmark
10 from telemetry.timeline import tracing_category_filter 10 from telemetry.timeline import tracing_category_filter
11 from telemetry.web_perf import timeline_based_measurement 11 from telemetry.web_perf import timeline_based_measurement
12 from telemetry.web_perf.metrics import memory_timeline 12 from telemetry.web_perf.metrics import memory_timeline
13 13
14 import page_sets 14 import page_sets
15 15
16 16
17 # See tr.v.Numeric.getSummarizedScalarNumericsWithNames() 17 # See tr.v.Numeric.getSummarizedScalarNumericsWithNames()
18 # https://github.com/catapult-project/catapult/blob/master/tracing/tracing/value /numeric.html#L323 18 # https://github.com/catapult-project/catapult/blob/master/tracing/tracing/value /numeric.html#L323
19 _IGNORED_STATS_RE = re.compile(r'_(std|count|max|min|sum|pct_\d{4}(_\d+)?)$') 19 _IGNORED_STATS_RE = re.compile(
20 r'(?<!dump)(?<!process)_(std|count|max|min|sum|pct_\d{4}(_\d+)?)$')
20 21
21 22
22 class _MemoryInfra(perf_benchmark.PerfBenchmark): 23 class _MemoryInfra(perf_benchmark.PerfBenchmark):
23 """Base class for new-generation memory benchmarks based on memory-infra. 24 """Base class for new-generation memory benchmarks based on memory-infra.
24 25
25 This benchmark records data using memory-infra (https://goo.gl/8tGc6O), which 26 This benchmark records data using memory-infra (https://goo.gl/8tGc6O), which
26 is part of chrome tracing, and extracts it using timeline-based measurements. 27 is part of chrome tracing, and extracts it using timeline-based measurements.
27 """ 28 """
28 29
29 # Subclasses can override this to use TBMv2 instead of TBMv1. 30 # Subclasses can override this to use TBMv2 instead of TBMv1.
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 of long running idle Gmail page """ 212 of long running idle Gmail page """
212 page_set = page_sets.LongRunningIdleGmailBackgroundPageSet 213 page_set = page_sets.LongRunningIdleGmailBackgroundPageSet
213 214
214 @classmethod 215 @classmethod
215 def Name(cls): 216 def Name(cls):
216 return 'memory.long_running_idle_gmail_background_tbmv2' 217 return 'memory.long_running_idle_gmail_background_tbmv2'
217 218
218 @classmethod 219 @classmethod
219 def ShouldDisable(cls, possible_browser): # http://crbug.com/616530 220 def ShouldDisable(cls, possible_browser): # http://crbug.com/616530
220 return cls.IsSvelte(possible_browser) 221 return cls.IsSvelte(possible_browser)
OLDNEW
« no previous file with comments | « no previous file | tools/perf/benchmarks/v8.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698