Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2069873003: Motown: Define MediaRenderer and make it the way we identify renderers. (Closed)

Created:
4 years, 6 months ago by dalesat
Modified:
4 years, 6 months ago
Reviewers:
kulakowski
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Motown: Define MediaRenderer and make it the way we identify renderers. Previous to this CL, we had no standard way to expose/identify renderers independent of media type. AudioTrack exposed the audio renderer in an audio-specific way, and there was no video renderer. This CL defines MediaRenderer, which largely replaces AudioTrack. It supports media type negotiation and provides access to the MediaTimelineControlSite and the MediaConsumer associated with a renderer. URLs have been removed from the media interface definitions altogether. R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b870086bb5fb5145219787576d8b6cd6ae0f5dca

Patch Set 1 #

Patch Set 2 : Fix build break...audio_track_controller.* gone for good. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+608 lines, -1376 lines) Patch
M examples/audio_play_test/play_tone.cc View 6 chunks +22 lines, -16 lines 0 comments Download
M examples/audio_play_test/play_wav.cc View 6 chunks +16 lines, -20 lines 0 comments Download
M examples/media_test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M examples/media_test/media_test.cc View 2 chunks +11 lines, -1 line 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/audio_server.mojom.dart View 9 chunks +24 lines, -8 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/audio_track.mojom.dart View 8 chunks +1 line, -615 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_factory.mojom.dart View 17 chunks +53 lines, -22 lines 0 comments Download
A + mojo/dart/packages/mojo_services/lib/mojo/media/media_renderer.mojom.dart View 24 chunks +205 lines, -406 lines 0 comments Download
M mojo/services/media/audio/interfaces/audio_server.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/media/audio/interfaces/audio_track.mojom View 2 chunks +0 lines, -41 lines 0 comments Download
M mojo/services/media/control/interfaces/media_factory.mojom View 3 chunks +9 lines, -5 lines 0 comments Download
M mojo/services/media/core/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + mojo/services/media/core/interfaces/media_renderer.mojom View 2 chunks +9 lines, -6 lines 0 comments Download
M services/media/audio/audio_server_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/media/audio/audio_server_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M services/media/audio/audio_track_impl.h View 4 chunks +18 lines, -10 lines 0 comments Download
M services/media/audio/audio_track_impl.cc View 10 chunks +52 lines, -48 lines 0 comments Download
M services/media/factory_service/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M services/media/factory_service/audio_track_controller.h View 1 1 chunk +0 lines, -46 lines 0 comments Download
M services/media/factory_service/audio_track_controller.cc View 1 1 chunk +0 lines, -56 lines 0 comments Download
M services/media/factory_service/factory_service.h View 1 chunk +3 lines, -1 line 0 comments Download
M services/media/factory_service/factory_service.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M services/media/factory_service/media_player_impl.h View 4 chunks +9 lines, -2 lines 0 comments Download
M services/media/factory_service/media_player_impl.cc View 6 chunks +18 lines, -10 lines 0 comments Download
M services/media/factory_service/media_sink_impl.h View 1 4 chunks +36 lines, -4 lines 0 comments Download
M services/media/factory_service/media_sink_impl.cc View 5 chunks +55 lines, -33 lines 0 comments Download
M services/media/factory_service/media_timeline_controller_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M services/media/factory_service/media_timeline_controller_impl.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M services/media/framework/util/conversion_pipeline_builder.cc View 2 chunks +38 lines, -0 lines 0 comments Download
M services/media/framework_ffmpeg/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dalesat
Please take a look. Thanks!
4 years, 6 months ago (2016-06-15 00:03:19 UTC) #3
kulakowski
bots are sad about audio_track_controller.h
4 years, 6 months ago (2016-06-15 16:27:45 UTC) #4
dalesat
PTAL
4 years, 6 months ago (2016-06-15 17:25:24 UTC) #5
kulakowski
lgtm
4 years, 6 months ago (2016-06-15 18:08:11 UTC) #6
dalesat
4 years, 6 months ago (2016-06-15 21:29:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b870086bb5fb5145219787576d8b6cd6ae0f5dca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698