services/media/factory_service/media_timeline_controller_impl.h - Issue 2069873003: Motown: Define MediaRenderer and make it the way we identify renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/media/factory_service/media_timeline_controller_impl.h

Issue 2069873003: Motown: Define MediaRenderer and make it the way we identify renderers. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Fix build break...audio_track_controller.* gone for good. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/media/factory_service/media_sink_impl.cc ('k') | services/media/factory_service/media_timeline_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/media/factory_service/media_timeline_controller_impl.h

diff --git a/services/media/factory_service/media_timeline_controller_impl.h b/services/media/factory_service/media_timeline_controller_impl.h

index c2b383a5c1a76238d6ac5e19d770f591339fd6b5..e12f73646db6429385c36b09e664731fbc136299 100644

--- a/services/media/factory_service/media_timeline_controller_impl.h

+++ b/services/media/factory_service/media_timeline_controller_impl.h

@@ -64,8 +64,6 @@ class MediaTimelineControllerImpl

SiteState(MediaTimelineControllerImpl* parent,

MediaTimelineControlSitePtr site);

- SiteState(SiteState&& other);

~SiteState();

void HandleStatusUpdates(

@@ -149,7 +147,7 @@ class MediaTimelineControllerImpl

Binding<MediaTimelineControlSite> control_site_binding_;

Binding<TimelineConsumer> consumer_binding_;

MojoPublisher<GetStatusCallback> status_publisher_;

- std::vector<SiteState> site_states_;

+ std::vector<std::unique_ptr<SiteState>> site_states_;

TimelineFunction current_timeline_function_;

bool end_of_stream_ = false;

std::weak_ptr<TimelineTransition> pending_transition_;