Fix Windows time zone name extraction. Update API docs

Fix Windows time zone name extraction. Update API docs

On Windows, the OS provides a full name for the time zone
rather than an abbreviation. Further the string may
contain non-ASCII characters, so a conversion is
necessary. This CL updates the API docs to match the
actual behavior, and fixes the string conversion problem.

fixes #17085

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/22e449ba09480f9294b2e168ff5e11fcc5883f5d

[zra, 2016-06-14 19:41:16]

Description was changed from

==========
Fix Windows time zone name extraction, and update docs

fixes #17085
==========

to

==========
Fix Windows time zone name extraction. Update API docs

On Windows, the OS provides a full name for the time zone
rather than an abbreviation. Further the string may
contain non-ASCII characters, so a conversion is
necessary. This CL updates the API docs to match the
actual behavior, and fixes the string conversion problem.

fixes #17085
==========

[zra, 2016-06-14 19:41:34]

zra@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-06-14 20:07:06]

lgtm

https://codereview.chromium.org/2069783002/diff/1/runtime/vm/os_win.cc
File runtime/vm/os_win.cc (right):

https://codereview.chromium.org/2069783002/diff/1/runtime/vm/os_win.cc#newcode65
runtime/vm/os_win.cc:65: // If we can't get the time zone data, fallback on PDT.
fallback on PST ?

In the past looks like we were returning "" why did you change that?

[zra, 2016-06-14 20:42:18]

https://codereview.chromium.org/2069783002/diff/1/runtime/vm/os_win.cc
File runtime/vm/os_win.cc (right):

https://codereview.chromium.org/2069783002/diff/1/runtime/vm/os_win.cc#newcode65
runtime/vm/os_win.cc:65: // If we can't get the time zone data, fallback on PDT.
On 2016/06/14 20:07:06, siva wrote:
> fallback on PST ?
> 
> In the past looks like we were returning "" why did you change that?

I didn't notice that on other platforms we also return "" on failure. I've
changed back to return "".

[zra, 2016-06-14 20:51:23]

Description was changed from

==========
Fix Windows time zone name extraction. Update API docs

On Windows, the OS provides a full name for the time zone
rather than an abbreviation. Further the string may
contain non-ASCII characters, so a conversion is
necessary. This CL updates the API docs to match the
actual behavior, and fixes the string conversion problem.

fixes #17085
==========

to

==========
Fix Windows time zone name extraction. Update API docs

On Windows, the OS provides a full name for the time zone
rather than an abbreviation. Further the string may
contain non-ASCII characters, so a conversion is
necessary. This CL updates the API docs to match the
actual behavior, and fixes the string conversion problem.

fixes #17085

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/22e449ba09480f9294b2e168ff5e11fcc5883f5d
==========

[zra, 2016-06-14 20:51:25]

Committed patchset #2 (id:20001) manually as
22e449ba09480f9294b2e168ff5e11fcc5883f5d (presubmit successful).

[floitsch, 2016-08-22 16:20:24]

floitsch@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2016-08-22 16:20:25]

The next time please add one of the library maintainers as reviewers when you
change the Core APIs.

https://codereview.chromium.org/2069783002/diff/20001/sdk/lib/core/date_time....
File sdk/lib/core/date_time.dart (right):

https://codereview.chromium.org/2069783002/diff/20001/sdk/lib/core/date_time....
sdk/lib/core/date_time.dart:667: * The time zone name provided by the platform.
No need to explicitly use the "provided by the platform" in the initial header
line.
Don't use future-tense in dartdocs, unless it happens after the call has
returned.
Talk about the browser. In the browser, even on windows, it's an abbreviation.

Maybe:

The time-zone name.

The actual value is provided by the operating system and may be an abbreviation
or a full name.

In the browser, or on Unix-like systems commonly returns abbreviations, such as
"CET", "CEST". On Windows returns the full name, for example "Pacific Standard
Time".

[zra, 2016-08-22 16:27:07]

On 2016/08/22 16:20:25, floitsch wrote:
> The next time please add one of the library maintainers as reviewers when you
> change the Core APIs.
> 
>
https://codereview.chromium.org/2069783002/diff/20001/sdk/lib/core/date_time....
> File sdk/lib/core/date_time.dart (right):
> 
>
https://codereview.chromium.org/2069783002/diff/20001/sdk/lib/core/date_time....
> sdk/lib/core/date_time.dart:667: * The time zone name provided by the
platform.
> No need to explicitly use the "provided by the platform" in the initial header
> line.
> Don't use future-tense in dartdocs, unless it happens after the call has
> returned.
> Talk about the browser. In the browser, even on windows, it's an abbreviation.
> 
> Maybe:
> 
> The time-zone name.
> 
> The actual value is provided by the operating system and may be an
abbreviation
> or a full name.
> 
> In the browser, or on Unix-like systems commonly returns abbreviations, such
as
> "CET", "CEST". On Windows returns the full name, for example "Pacific Standard
> Time".

Happy to review the CL if you want to make these changes.