Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2069563002: [json] detect overflow sooner when serializing large sparse array. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
Reviewers:
Michael Lippautz, Yuki
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[json] detect overflow sooner when serializing large sparse array. R=mlippautz@chromium.org, yukishiino@chromium.org BUG=chromium:617649 Committed: https://crrev.com/19067e5fbc3da97f87a4b430a1b589529723cdbd Cr-Commit-Position: refs/heads/master@{#36961}

Patch Set 1 #

Patch Set 2 : check string length upfront #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/json-stringifier.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/string-builder.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
4 years, 6 months ago (2016-06-14 09:57:05 UTC) #1
Yuki
LGTM from my perspective.
4 years, 6 months ago (2016-06-14 10:20:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069563002/20001
4 years, 6 months ago (2016-06-14 11:04:30 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-14 11:34:26 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 11:37:14 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/19067e5fbc3da97f87a4b430a1b589529723cdbd
Cr-Commit-Position: refs/heads/master@{#36961}

Powered by Google App Engine
This is Rietveld 408576698