src/string-builder.h - Issue 2069563002: [json] detect overflow sooner when serializing large sparse array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/string-builder.h

Issue 2069563002: [json] detect overflow sooner when serializing large sparse array. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: check string length upfront Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/string-builder.h

diff --git a/src/string-builder.h b/src/string-builder.h

index b92bb96e5e02f3c59a0b00faacce0873e1d9b5e2..192603f33f98025b7171554b7b2dc5c0eef6be0c 100644

--- a/src/string-builder.h

+++ b/src/string-builder.h

@@ -309,6 +309,8 @@ class IncrementalStringBuilder {

MaybeHandle<String> Finish();

+ INLINE(bool HasOverflowed()) const { return overflowed_; }

// Change encoding to two-byte.

void ChangeEncoding() {

DCHECK_EQ(String::ONE_BYTE_ENCODING, encoding_);

« no previous file with comments | « src/json-stringifier.cc ('k') | no next file » | no next file with comments »