Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2069533002: Have CanvasAsyncBlobCreator's delayed task keep a weak |this| also. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have CanvasAsyncBlobCreator's delayed task keep a weak |this| also. Followup r399445 and dually have the delayed task that's posted to check if the idle task has gone ahead, also keep a weak |this| reference. The non-winning CanvasAsyncBlobCreator posted main thread tasks can safely be cancelled & dropped if a GC happens to go ahead. R= BUG= Committed: https://crrev.com/c0db5076c1c2b626aec53e2c8023b79e27820959 Cr-Commit-Position: refs/heads/master@{#399675}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look. my bad, I should have realized the need for this dual ...
4 years, 6 months ago (2016-06-14 08:17:22 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-14 08:20:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069533002/1
4 years, 6 months ago (2016-06-14 08:22:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 09:53:56 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c0db5076c1c2b626aec53e2c8023b79e27820959 Cr-Commit-Position: refs/heads/master@{#399675}
4 years, 6 months ago (2016-06-14 09:56:30 UTC) #8
Zhen Wang
4 years, 6 months ago (2016-06-14 20:19:31 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2062243003/ by zhenw@chromium.org.

The reason for reverting is: This CL makes blink_perf.canvas fail on perf bots.
See the bug for details.

BUG=620043.

Powered by Google App Engine
This is Rietveld 408576698