Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2062243003: Revert of Have CanvasAsyncBlobCreator's delayed task keep a weak |this| also. (Closed)

Created:
4 years, 6 months ago by Zhen Wang
Modified:
4 years, 6 months ago
Reviewers:
haraken, sof
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Have CanvasAsyncBlobCreator's delayed task keep a weak |this| also. (patchset #1 id:1 of https://codereview.chromium.org/2069533002/ ) Reason for revert: This CL makes blink_perf.canvas fail on perf bots. See the bug for details. BUG=620043 Original issue's description: > Have CanvasAsyncBlobCreator's delayed task keep a weak |this| also. > > Followup r399445 and dually have the delayed task that's > posted to check if the idle task has gone ahead, also keep > a weak |this| reference. The non-winning CanvasAsyncBlobCreator > posted main thread tasks can safely be cancelled & dropped if > a GC happens to go ahead. > > R= > BUG= > > Committed: https://crrev.com/c0db5076c1c2b626aec53e2c8023b79e27820959 > Cr-Commit-Position: refs/heads/master@{#399675} TBR=haraken@chromium.org,sigbjornf@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/b70b7547d75b6e121972c99cc6eaab6e116f2e88 Cr-Commit-Position: refs/heads/master@{#399775}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Zhen Wang
Created Revert of Have CanvasAsyncBlobCreator's delayed task keep a weak |this| also.
4 years, 6 months ago (2016-06-14 20:19:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062243003/1
4 years, 6 months ago (2016-06-14 20:19:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 20:20:41 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b70b7547d75b6e121972c99cc6eaab6e116f2e88 Cr-Commit-Position: refs/heads/master@{#399775}
4 years, 6 months ago (2016-06-14 20:22:08 UTC) #7
haraken
LGTM
4 years, 6 months ago (2016-06-14 23:42:25 UTC) #8
sof
4 years, 6 months ago (2016-06-15 07:03:27 UTC) #9
Message was sent while issue was closed.
lgtm, thanks for reverting.

Powered by Google App Engine
This is Rietveld 408576698