chrome/browser/permissions/permission_bubble_request_impl.cc - Issue 2069343002: Pass profile to PermissionUmaUtil::PermissionIgnored

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_bubble_request_impl.cc

Issue 2069343002: Pass profile to PermissionUmaUtil::PermissionIgnored (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-hooks-to-permission-layer

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_bubble_request_impl.h ('k') | chrome/browser/permissions/permission_context_base.cc » ('j') | chrome/browser/permissions/permission_uma_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_bubble_request_impl.cc

diff --git a/chrome/browser/permissions/permission_bubble_request_impl.cc b/chrome/browser/permissions/permission_bubble_request_impl.cc

index 2ae3098f072b4b1bf4ad60ae9b2db7b2a4e4f66f..0dd707d129adc1140108f7b71154fd4d38f19472 100644

--- a/chrome/browser/permissions/permission_bubble_request_impl.cc

+++ b/chrome/browser/permissions/permission_bubble_request_impl.cc

@@ -17,10 +17,12 @@

PermissionBubbleRequestImpl::PermissionBubbleRequestImpl(

const GURL& request_origin,

content::PermissionType permission_type,

+ Profile* profile,

const PermissionDecidedCallback& permission_decided_callback,

const base::Closure delete_callback)

: request_origin_(request_origin),

permission_type_(permission_type),

+ profile_(profile),

permission_decided_callback_(permission_decided_callback),

delete_callback_(delete_callback),

is_finished_(false),

@@ -29,9 +31,8 @@ PermissionBubbleRequestImpl::PermissionBubbleRequestImpl(

PermissionBubbleRequestImpl::~PermissionBubbleRequestImpl() {

DCHECK(is_finished_);

if (!action_taken_)

- // TODO(stefanocs): Pass in a non null profile.

PermissionUmaUtil::PermissionIgnored(permission_type_, request_origin_,

- nullptr);

+ profile_);

}

gfx::VectorIconId PermissionBubbleRequestImpl::GetVectorIconId() const {