chrome/browser/permissions/permission_uma_util.cc - Issue 2069343002: Pass profile to PermissionUmaUtil::PermissionIgnored

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2069343002: Pass profile to PermissionUmaUtil::PermissionIgnored (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-hooks-to-permission-layer

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/permissions/permission_uma_util.cc

diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc

index 70324dd516908e38589b4eabab7780f1869396de..64de5807ecc93e68532c0a018ac6b142dca54e16 100644

--- a/chrome/browser/permissions/permission_uma_util.cc

+++ b/chrome/browser/permissions/permission_uma_util.cc

@@ -299,10 +299,6 @@ bool PermissionUmaUtil::IsOptedIntoPermissionActionReporting(Profile* profile) {

if (!base::CommandLine::ForCurrentProcess()->HasSwitch(

switches::kEnablePermissionActionReporting))

return false;

- // TODO(stefanocs): Remove this check once all callsites have been updated

- // to not pass a nullptr.

- if (!profile)

timvolodine 2016/07/20 18:19:58 should there be DCHECK(profile) now?

- return false;

if (profile->GetProfileType() == Profile::INCOGNITO_PROFILE)

return false;

if (!profile->GetPrefs()->GetBoolean(prefs::kSafeBrowsingEnabled))

« no previous file with comments | « chrome/browser/permissions/permission_queue_controller.cc ('k') | no next file » | no next file with comments »