Pass profile to PermissionUmaUtil::PermissionIgnored

Pass profile to PermissionUmaUtil::PermissionIgnored

PermissionUmaUtil::PermissionIgnored is previously called with nullptr passed for the profile parameter.

BUG=613883
Committed: https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f
Cr-Commit-Position: refs/heads/master@{#406766}

[stefanocs, 2016-06-16 05:08:39]

Description was changed from

==========
Add profile data to PermissionUmaUtil::PermissionIgnored

BUG=613883
==========

to

==========
Add profile data to PermissionUmaUtil::PermissionIgnored

PermissionUmaUtil::PermissionIgnored is previously called with nullptr passed
for the profile parameter.

BUG=613883
==========

[stefanocs, 2016-06-16 05:31:22]

Description was changed from

==========
Add profile data to PermissionUmaUtil::PermissionIgnored

PermissionUmaUtil::PermissionIgnored is previously called with nullptr passed
for the profile parameter.

BUG=613883
==========

to

==========
Pass profile to PermissionUmaUtil::PermissionIgnored

PermissionUmaUtil::PermissionIgnored is previously called with nullptr passed
for the profile parameter.

BUG=613883
==========

[stefanocs, 2016-06-16 05:32:06]

stefanocs@google.com changed reviewers:
+ kcarattini@chromium.org, raymes@chromium.org

[raymes, 2016-06-20 01:38:57]

On 2016/06/16 05:32:07, stefanocs wrote:

I'll hold off on reviewing this until we land Issue 2047253002 (please ping me
if I forget about it :)

[stefanocs, 2016-07-13 06:28:04]

ping :)

[kcarattini, 2016-07-13 06:40:11]

lgtm

[raymes, 2016-07-14 03:59:41]

lgtm - can we remove the nullptr check in IsOptedIntoPermissionActionReporting
now?

[stefanocs, 2016-07-15 01:34:17]

stefanocs@google.com changed reviewers:
+ sergeyu@chromium.org, stevenjb@chromium.org, timvolodine@chromium.org

[stefanocs, 2016-07-15 01:34:18]

Done, thanks!

timvolodine@chromium.org: Please review changes in 
chrome/browser/geolocation

stevenjb@chromium.org: Please review changes in 
chrome/browser/notifications

sergeyu@chromium.org: Please review changes in chrome/browser/media

[stefanocs, 2016-07-15 05:23:02]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 05:23:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stefanocs, 2016-07-15 10:27:50]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 10:28:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 11:52:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 11:52:13]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2016-07-18 15:47:38]

c/b/notifications lgtm

[stefanocs, 2016-07-19 01:00:07]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 01:01:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 02:30:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 02:30:15]

Dry run: This issue passed the CQ dry run.

[stefanocs, 2016-07-19 10:44:08]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 10:44:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stefanocs, 2016-07-19 11:05:16]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 11:05:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 11:44:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 11:44:12]

Dry run: This issue passed the CQ dry run.

[timvolodine, 2016-07-20 18:19:58]

chrome/browser/geolocation -- lgtm

https://codereview.chromium.org/2069343002/diff/200001/chrome/browser/permiss...
File chrome/browser/permissions/permission_uma_util.cc (left):

https://codereview.chromium.org/2069343002/diff/200001/chrome/browser/permiss...
chrome/browser/permissions/permission_uma_util.cc:304: if (!profile)
should there be DCHECK(profile) now?

[Sergey Ulanov, 2016-07-20 18:46:43]

lgtm

[stefanocs, 2016-07-21 00:06:41]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 00:07:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 00:09:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 00:09:39]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[stefanocs, 2016-07-21 00:24:41]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 00:25:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 00:28:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 00:28:05]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[stefanocs, 2016-07-21 00:49:32]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 00:49:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 01:20:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 01:20:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stefanocs, 2016-07-21 02:26:10]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 02:26:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stefanocs, 2016-07-21 02:26:54]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 02:27:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 03:25:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 03:25:58]

Dry run: This issue passed the CQ dry run.

[stefanocs, 2016-07-21 04:16:10]

The CQ bit was checked by stefanocs@google.com

[stefanocs, 2016-07-21 04:16:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
kcarattini@chromium.org, raymes@chromium.org, stevenjb@chromium.org,
sergeyu@chromium.org, timvolodine@chromium.org
Link to the patchset: https://codereview.chromium.org/2069343002/#ps270001
(title: "merge")

[commit-bot: I haz the power, 2016-07-21 04:16:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 04:24:29]

Description was changed from

==========
Pass profile to PermissionUmaUtil::PermissionIgnored

PermissionUmaUtil::PermissionIgnored is previously called with nullptr passed
for the profile parameter.

BUG=613883
==========

to

==========
Pass profile to PermissionUmaUtil::PermissionIgnored

PermissionUmaUtil::PermissionIgnored is previously called with nullptr passed
for the profile parameter.

BUG=613883
==========

[commit-bot: I haz the power, 2016-07-21 04:24:31]

Committed patchset #15 (id:270001)

[commit-bot: I haz the power, 2016-07-21 04:26:47]

Description was changed from

==========
Pass profile to PermissionUmaUtil::PermissionIgnored

PermissionUmaUtil::PermissionIgnored is previously called with nullptr passed
for the profile parameter.

BUG=613883
==========

to

==========
Pass profile to PermissionUmaUtil::PermissionIgnored

PermissionUmaUtil::PermissionIgnored is previously called with nullptr passed
for the profile parameter.

BUG=613883

Committed: https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f
Cr-Commit-Position: refs/heads/master@{#406766}
==========

[commit-bot: I haz the power, 2016-07-21 04:26:49]

Patchset 15 (id:??) landed as
https://crrev.com/a5fb0e4be3c528a8882ec4288edc20dda14d387f
Cr-Commit-Position: refs/heads/master@{#406766}