Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3143)

Unified Diff: chrome/browser/permissions/permission_request_impl.cc

Issue 2069343002: Pass profile to PermissionUmaUtil::PermissionIgnored (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-hooks-to-permission-layer
Patch Set: merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_request_impl.cc
diff --git a/chrome/browser/permissions/permission_request_impl.cc b/chrome/browser/permissions/permission_request_impl.cc
index a9d63b324eaeac0486331370a74d31ed56bd6ab9..76dd12678f090a72eddc667f3ab57ae60b826d11 100644
--- a/chrome/browser/permissions/permission_request_impl.cc
+++ b/chrome/browser/permissions/permission_request_impl.cc
@@ -17,10 +17,12 @@
PermissionRequestImpl::PermissionRequestImpl(
const GURL& request_origin,
content::PermissionType permission_type,
+ Profile* profile,
const PermissionDecidedCallback& permission_decided_callback,
const base::Closure delete_callback)
: request_origin_(request_origin),
permission_type_(permission_type),
+ profile_(profile),
permission_decided_callback_(permission_decided_callback),
delete_callback_(delete_callback),
is_finished_(false),
@@ -28,10 +30,10 @@ PermissionRequestImpl::PermissionRequestImpl(
PermissionRequestImpl::~PermissionRequestImpl() {
DCHECK(is_finished_);
- if (!action_taken_)
- // TODO(stefanocs): Pass in a non null profile.
+ if (!action_taken_) {
PermissionUmaUtil::PermissionIgnored(permission_type_, request_origin_,
- nullptr);
+ profile_);
+ }
}
gfx::VectorIconId PermissionRequestImpl::GetVectorIconId() const {
« no previous file with comments | « chrome/browser/permissions/permission_request_impl.h ('k') | chrome/browser/permissions/permission_uma_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698