ui/webui/resources/cr_elements/network/compiled_resources2.gyp - Issue 2069323002: Add support for custom entries in <cr_network_select/>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/network/compiled_resources2.gyp

Issue 2069323002: Add support for custom entries in <cr_network_select/>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@604119--Implement-Chrome-OS-out-of-box-flow-in-Material-Design--ImplementNetworkSelectionScreen

Patch Set: Split cr-network-list into two dom-repeat objects/. Removed list_item_base. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | ui/webui/resources/cr_elements/network/cr_network_list.html » ('j') | ui/webui/resources/cr_elements/network/cr_network_list_custom_item.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/cr_elements/network/compiled_resources2.gyp

diff --git a/ui/webui/resources/cr_elements/network/compiled_resources2.gyp b/ui/webui/resources/cr_elements/network/compiled_resources2.gyp

index 2a193a33100eb48cdbf59cacc0d0b3c3f3dfe108..628a35ed09c7e0f39becd3ed28fd7aff32684355 100644

--- a/ui/webui/resources/cr_elements/network/compiled_resources2.gyp

+++ b/ui/webui/resources/cr_elements/network/compiled_resources2.gyp

@@ -22,7 +22,23 @@

'includes': ['../../../../../third_party/closure_compiler/compile_js2.gypi'],

{

- 'target_name': 'cr_network_list_item',

+ 'target_name': 'cr_network_list_custom_item',

+ 'dependencies': [

+ '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:load_time_data',

+ 'cr_onc_types',

+ ],

+ 'includes': ['../../../../../third_party/closure_compiler/compile_js2.gypi'],

+ },

+ {

+ 'target_name': 'cr_network_list_network_item',

+ 'dependencies': [

+ '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:load_time_data',

+ 'cr_onc_types',

+ ],

+ 'includes': ['../../../../../third_party/closure_compiler/compile_js2.gypi'],

+ },

+ {

+ 'target_name': 'cr_network_list_network_item',

stevenjb 2016/06/24 22:33:08 Duplicate?

Alexander Alekseev 2016/06/25 06:04:43 Done.

'dependencies': [

'<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:load_time_data',

'cr_onc_types',