chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc - Issue 2069323002: Add support for custom entries in <cr_network_select/>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2069323002: Add support for custom entries in <cr_network_select/>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@604119--Implement-Chrome-OS-out-of-box-flow-in-Material-Design--ImplementNetworkSelectionScreen

Patch Set: Split cr-network-list into two dom-repeat objects/. Removed list_item_base. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/network_summary_item.html ('k') | ui/webui/resources/cr_elements/network/compiled_resources2.gyp » ('j') | ui/webui/resources/cr_elements/network/compiled_resources2.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

index db1ac32f9b89ea4c1e18fc531c975c76e4fe4a4f..b598a2fdfdfb28d656829f047161c16373b62c15 100644

--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -559,7 +559,7 @@ void AddInternetStrings(content::WebUIDataSource* html_source) {

{"internetPageTitle", IDS_SETTINGS_INTERNET},

{"internetDetailPageTitle", IDS_SETTINGS_INTERNET_DETAIL},

{"internetKnownNetworksPageTitle", IDS_SETTINGS_INTERNET_KNOWN_NETWORKS},

- // Required by cr_network_list_item.js. TODO(stevenjb): Add to

+ // Required by cr_network_list_network_item.js. TODO(stevenjb): Add to

// settings_strings.grdp or provide an alternative translation method.

// crbug.com/512214.

{"networkConnected", IDS_ASH_STATUS_TRAY_NETWORK_CONNECTED},