components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java - Issue 2069303002: Add new Cronet exception class for QUIC errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java

Issue 2069303002: Add new Cronet exception class for QUIC errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add UrlRequestException top-level error for QUIC, and other comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/api/src/org/chromium/net/UrlRequestException.java ('K') | « components/cronet/android/cronet_url_request_adapter.cc ('k') | components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java

diff --git a/components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java b/components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java

index 5e943043e1d490592c137c0a7cccb463a0ff1b4c..0422df300f2de159c04c34e156ffeb993b97abed 100644

--- a/components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java

+++ b/components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java

@@ -555,13 +555,18 @@ class CronetBidirectionalStream extends BidirectionalStream {

@SuppressWarnings("unused")

@CalledByNative

- private void onError(

- int errorCode, int nativeError, String errorString, long receivedBytesCount) {

+ private void onError(int errorCode, int nativeError, int nativeQuicError, String errorString,

+ long receivedBytesCount) {

pauljensen 2016/07/01 12:22:02 ugh, duplicated code... fixing is not for this CL

if (mResponseInfo != null) {

mResponseInfo.setReceivedBytesCount(receivedBytesCount);

}

- failWithException(new CronetException(

- "Exception in BidirectionalStream: " + errorString, errorCode, nativeError));

+ if (errorCode == UrlRequestException.ERROR_QUIC_PROTOCOL_FAILED) {

+ failWithException(new QuicException("Exception in BidirectionalStream: " + errorString,

+ nativeError, nativeQuicError));

+ } else {

+ failWithException(new CronetException(

+ "Exception in BidirectionalStream: " + errorString, errorCode, nativeError));

+ }

}

/**