components/cronet/android/api/src/org/chromium/net/UrlRequestException.java - Issue 2069303002: Add new Cronet exception class for QUIC errors

Unified Diff: components/cronet/android/api/src/org/chromium/net/UrlRequestException.java

Issue 2069303002: Add new Cronet exception class for QUIC errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add UrlRequestException top-level error for QUIC, and other comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/api/src/org/chromium/net/QuicException.java ('K') | « components/cronet/android/api/src/org/chromium/net/QuicException.java ('k') | components/cronet/android/cronet_bidirectional_stream_adapter.cc » ('j') | components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/api/src/org/chromium/net/UrlRequestException.java

diff --git a/components/cronet/android/api/src/org/chromium/net/UrlRequestException.java b/components/cronet/android/api/src/org/chromium/net/UrlRequestException.java

index 92201aa32471128ce721a81cab80fbf8b061f73b..22360b01d018cc1f0dab9a2b99e380494e455be3 100644

--- a/components/cronet/android/api/src/org/chromium/net/UrlRequestException.java

+++ b/components/cronet/android/api/src/org/chromium/net/UrlRequestException.java

@@ -14,7 +14,10 @@ import java.io.IOException;

* {@link #getErrorCode} will return {@link #ERROR_LISTENER_EXCEPTION_THROWN}.

* <li>Cronet fails to process a network request. In this case

* {@link #getErrorCode} and {@link #getCronetInternalErrorCode} can be used to get more

- * information about the specific type of failure.

+ * information about the specific type of failure. If {@link #getErrorCode}

+ * returns {@link #ERROR_QUIC_PROTOCOL_FAILED}, this exception can be cast to a

+ * {@link QuicException}

pauljensen 2016/07/01 12:22:02 funky line wrapping

mgersh 2016/07/01 15:21:15 Done.

+ * which can provide further details.

* </ul>

public class UrlRequestException extends IOException {

@@ -64,6 +67,10 @@ public class UrlRequestException extends IOException {

public static final int ERROR_ADDRESS_UNREACHABLE = UrlRequestError.ADDRESS_UNREACHABLE;

/**

+ * Error code indicating an error related to the QUIC protocol.

pauljensen 2016/07/01 12:22:02 mention this class can be cast to QuicException fo

pauljensen 2016/07/01 12:22:02 linkify QUIC

mgersh 2016/07/01 15:21:15 Done.

+ */

+ public static final int ERROR_QUIC_PROTOCOL_FAILED = UrlRequestError.QUIC_PROTOCOL_FAILED;

+ /**

* Error code indicating another type of error was encountered.

* {@link #getCronetInternalErrorCode} can be consulted to get a more specific cause.