Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

Issue 2069303002: Add new Cronet exception class for QUIC errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
index 475d67f21128225cc6f22df2b9d7b9ca62298dcd..486f8c2d75b1295612afc0909733d3b4d182d1a8 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
@@ -1779,6 +1779,22 @@ public class CronetUrlRequestTest extends CronetTestBase {
assertEquals("Header not found. :(", callback2.mResponseAsString);
}
+ @SmallTest
+ @Feature({"Cronet"})
+ @OnlyRunNativeCronet
+ public void testQuicErrorCode() throws Exception {
+ // -356 is QUIC_PROTOCOL_ERROR
+ int quicProtocolError = -356;
+ TestUrlRequestCallback callback =
+ startAndWaitForComplete(MockUrlRequestJobFactory.getMockUrlWithFailure(
+ FailurePhase.START, quicProtocolError));
+ assertNull(callback.mResponseInfo);
+ assertNotNull(callback.mError);
+ assertEquals(quicProtocolError, callback.mError.getCronetInternalErrorCode());
+ // 1 is QUIC_INTERNAL_ERROR
+ assertEquals(1, callback.mError.getCronetInternalErrorDetails());
+ }
+
private void checkSpecificErrorCode(int netError, int errorCode, String name,
boolean immediatelyRetryable) throws Exception {
TestUrlRequestCallback callback = startAndWaitForComplete(

Powered by Google App Engine
This is Rietveld 408576698