Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: components/cronet/android/cronet_bidirectional_stream_adapter.cc

Issue 2069303002: Add new Cronet exception class for QUIC errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/cronet_bidirectional_stream_adapter.cc
diff --git a/components/cronet/android/cronet_bidirectional_stream_adapter.cc b/components/cronet/android/cronet_bidirectional_stream_adapter.cc
index 557c8f47eebc4608e9f2987099d6065dd2542ae6..6e5bea145f789e5838b751aef636fb16ab30f699 100644
--- a/components/cronet/android/cronet_bidirectional_stream_adapter.cc
+++ b/components/cronet/android/cronet_bidirectional_stream_adapter.cc
@@ -315,8 +315,9 @@ void CronetBidirectionalStreamAdapter::OnFailed(int error) {
DCHECK(context_->IsOnNetworkThread());
stream_failed_ = true;
JNIEnv* env = base::android::AttachCurrentThread();
+ // TODO(mgersh): Add support for NetErrorDetails
cronet::Java_CronetBidirectionalStream_onError(
- env, owner_.obj(), NetErrorToUrlRequestError(error), error,
+ env, owner_.obj(), NetErrorToUrlRequestError(error), error, 0,
pauljensen 2016/06/17 12:05:59 0 -> QUIC_NO_ERROR
mgersh 2016/06/29 23:01:09 Done (here and in the next file)
ConvertUTF8ToJavaString(env, net::ErrorToString(error)).obj(),
bidi_stream_->GetTotalReceivedBytes());
}

Powered by Google App Engine
This is Rietveld 408576698