Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 2069213002: Proguard warning suppresions removed (Closed)

Created:
4 years, 6 months ago by smaier
Modified:
4 years, 3 months ago
Reviewers:
Peter Wen, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Proguard warning suppresions removed Old warning suppressions are kept in proguard.flags file without anyone caring about them. It seems like removing them has absolutely no effect. BUG=619937 Committed: https://crrev.com/717861ebc8fd72bcca825c4d5049047a75afd34c Cr-Commit-Position: refs/heads/master@{#400676}

Patch Set 1 #

Patch Set 2 : Removed some associated comments #

Patch Set 3 : Re added org.apache dontwarn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M chrome/android/java/proguard.flags View 1 2 3 chunks +3 lines, -18 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
smaier
4 years, 6 months ago (2016-06-15 19:31:37 UTC) #2
agrieve
On 2016/06/15 19:31:37, smaier wrote: lgtm
4 years, 6 months ago (2016-06-16 00:53:00 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069213002/20001
4 years, 6 months ago (2016-06-16 00:53:15 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/88469)
4 years, 6 months ago (2016-06-16 01:18:42 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069213002/40001
4 years, 6 months ago (2016-06-16 15:50:23 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-16 16:27:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069213002/40001
4 years, 6 months ago (2016-06-20 13:40:52 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-20 14:20:17 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/717861ebc8fd72bcca825c4d5049047a75afd34c Cr-Commit-Position: refs/heads/master@{#400676}
4 years, 6 months ago (2016-06-20 14:25:11 UTC) #17
aelias_OOO_until_Jul13
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2084013004/ by aelias@chromium.org. ...
4 years, 6 months ago (2016-06-21 21:41:04 UTC) #18
aelias_OOO_until_Jul13
On 2016/06/21 at 21:41:04, aelias wrote: > A revert of this CL (patchset #3 id:40001) ...
4 years, 6 months ago (2016-06-22 19:06:03 UTC) #19
Ken Rockot(use gerrit already)
On 2016/06/22 at 19:06:03, aelias wrote: > On 2016/06/21 at 21:41:04, aelias wrote: > > ...
4 years, 5 months ago (2016-06-28 23:14:04 UTC) #20
agrieve
4 years, 5 months ago (2016-06-29 00:34:13 UTC) #21
Message was sent while issue was closed.
On 2016/06/28 23:14:04, Ken Rockot wrote:
> On 2016/06/22 at 19:06:03, aelias wrote:
> > On 2016/06/21 at 21:41:04, aelias wrote:
> > > A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/2084013004/ by mailto:aelias@chromium.org.
> > > 
> > > The reason for reverting is: Reverting on behalf of sheriff, breaks
> arm64-builder-rel due to SslCertificate suppression still being needed..
> > 
> > For the record, it wasn't reverted after all because we identified the bot
> actually wasn't broken by this patch.
> 
> What ended up being the cause of the SslCertificate errors on the builder if
not
> affected by the suppression? I'm hitting similar errors locally now on a clean
> ToT build and therefore cannot build chrome_public_apk.

I think it's still broken in a non-clank checkout due to the recent play
services roll goofing up a bit. Fix is here:
https://codereview.chromium.org/2103193002/.

Powered by Google App Engine
This is Rietveld 408576698