|
|
DescriptionProguard warning suppresions removed
Old warning suppressions are kept in proguard.flags file without anyone
caring about them. It seems like removing them has absolutely no effect.
BUG=619937
Committed: https://crrev.com/717861ebc8fd72bcca825c4d5049047a75afd34c
Cr-Commit-Position: refs/heads/master@{#400676}
Patch Set 1 #Patch Set 2 : Removed some associated comments #Patch Set 3 : Re added org.apache dontwarn #Messages
Total messages: 21 (8 generated)
smaier@chromium.org changed reviewers: + agrieve@chromium.org, wnwen@chromium.org
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
On 2016/06/15 19:31:37, smaier wrote: lgtm
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069213002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by smaier@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069213002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by smaier@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org Link to the patchset: https://codereview.chromium.org/2069213002/#ps40001 (title: "Re added org.apache dontwarn")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069213002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Proguard warning suppresions removed Old warning suppressions are kept in proguard.flags file without anyone caring about them. It seems like removing them has absolutely no effect. BUG=619937 ========== to ========== Proguard warning suppresions removed Old warning suppressions are kept in proguard.flags file without anyone caring about them. It seems like removing them has absolutely no effect. BUG=619937 Committed: https://crrev.com/717861ebc8fd72bcca825c4d5049047a75afd34c Cr-Commit-Position: refs/heads/master@{#400676} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/717861ebc8fd72bcca825c4d5049047a75afd34c Cr-Commit-Position: refs/heads/master@{#400676}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2084013004/ by aelias@chromium.org. The reason for reverting is: Reverting on behalf of sheriff, breaks arm64-builder-rel due to SslCertificate suppression still being needed..
Message was sent while issue was closed.
On 2016/06/21 at 21:41:04, aelias wrote: > A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2084013004/ by aelias@chromium.org. > > The reason for reverting is: Reverting on behalf of sheriff, breaks arm64-builder-rel due to SslCertificate suppression still being needed.. For the record, it wasn't reverted after all because we identified the bot actually wasn't broken by this patch.
Message was sent while issue was closed.
On 2016/06/22 at 19:06:03, aelias wrote: > On 2016/06/21 at 21:41:04, aelias wrote: > > A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2084013004/ by aelias@chromium.org. > > > > The reason for reverting is: Reverting on behalf of sheriff, breaks arm64-builder-rel due to SslCertificate suppression still being needed.. > > For the record, it wasn't reverted after all because we identified the bot actually wasn't broken by this patch. What ended up being the cause of the SslCertificate errors on the builder if not affected by the suppression? I'm hitting similar errors locally now on a clean ToT build and therefore cannot build chrome_public_apk.
Message was sent while issue was closed.
On 2016/06/28 23:14:04, Ken Rockot wrote: > On 2016/06/22 at 19:06:03, aelias wrote: > > On 2016/06/21 at 21:41:04, aelias wrote: > > > A revert of this CL (patchset #3 id:40001) has been created in > https://codereview.chromium.org/2084013004/ by mailto:aelias@chromium.org. > > > > > > The reason for reverting is: Reverting on behalf of sheriff, breaks > arm64-builder-rel due to SslCertificate suppression still being needed.. > > > > For the record, it wasn't reverted after all because we identified the bot > actually wasn't broken by this patch. > > What ended up being the cause of the SslCertificate errors on the builder if not > affected by the suppression? I'm hitting similar errors locally now on a clean > ToT build and therefore cannot build chrome_public_apk. I think it's still broken in a non-clank checkout due to the recent play services roll goofing up a bit. Fix is here: https://codereview.chromium.org/2103193002/. |