[Tracing] Set os-name to CrOS in trace metadata, and get the correct version for it

[Tracing] Set os-name to CrOS in trace metadata, and get the correct version for it

BUG=

Review-Url: https://codereview.chromium.org/2068843002
Cr-Commit-Position: refs/heads/master@{#467830}
Committed: https://chromium.googlesource.com/chromium/src/+/6120633f339b49ea3503dbf86764c55c77e12335

[fmeawad, 2016-06-17 21:27:37]

fmeawad@chromium.org changed reviewers:
+ oysteine@chromium.org

[fmeawad, 2016-06-17 21:27:37]

PTAL.

I have not tested it yet, I will before landing.

[oystein (OOO til 10th of July), 2016-06-19 08:59:44]

Great, thanks!

lgtm w/ comments

https://codereview.chromium.org/2068843002/diff/20001/content/browser/tracing...
File content/browser/tracing/tracing_controller_impl.cc (right):

https://codereview.chromium.org/2068843002/diff/20001/content/browser/tracing...
content/browser/tracing/tracing_controller_impl.cc:125:
base::SysInfo::OperatingSystemVersionNumbers(&major_version, &minor_version,
What's the functional difference between setting os-version like this, and the
base::SysInfo::OperatingSystemVersion() below? A comment explaining why would
probably be good :).

https://codereview.chromium.org/2068843002/diff/20001/content/browser/tracing...
content/browser/tracing/tracing_controller_impl.cc:130: #elif
#else i guess :)

[fmeawad, 2017-04-27 21:01:13]

The CQ bit was checked by fmeawad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:02:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fmeawad, 2017-04-27 21:02:11]

I finally got around to testing this CL on chromeos, can you Take another look.

[oystein (OOO til 10th of July), 2017-04-27 21:05:16]

lgtm :)

https://codereview.chromium.org/2068843002/diff/40001/content/browser/tracing...
File content/browser/tracing/tracing_controller_impl.cc (right):

https://codereview.chromium.org/2068843002/diff/40001/content/browser/tracing...
content/browser/tracing/tracing_controller_impl.cc:845: //
OperatingSystemVersion on has a POSIX implementation which returns the
-on?

[fmeawad, 2017-04-27 21:17:10]

The CQ bit was checked by fmeawad@chromium.org

[fmeawad, 2017-04-27 21:17:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
oysteine@chromium.org
Link to the patchset: https://codereview.chromium.org/2068843002/#ps60001
(title: "Fix comment")

[fmeawad, 2017-04-27 21:17:25]

https://codereview.chromium.org/2068843002/diff/40001/content/browser/tracing...
File content/browser/tracing/tracing_controller_impl.cc (right):

https://codereview.chromium.org/2068843002/diff/40001/content/browser/tracing...
content/browser/tracing/tracing_controller_impl.cc:845: //
OperatingSystemVersion on has a POSIX implementation which returns the
On 2017/04/27 21:05:16, oystein wrote:
> -on?

Done.

[commit-bot: I haz the power, 2017-04-27 21:17:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 02:04:15]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493327830182210,
"parent_rev": "df9e0a31bddb2e31376f1e60a60e2a8fbae83f40", "commit_rev":
"6120633f339b49ea3503dbf86764c55c77e12335"}

[commit-bot: I haz the power, 2017-04-28 02:04:34]

Description was changed from

==========
[Tracing] Set os-name to CrOS in trace metadata, and get the correct version for
it

BUG=
==========

to

==========
[Tracing] Set os-name to CrOS in trace metadata, and get the correct version for
it

BUG=

Review-Url: https://codereview.chromium.org/2068843002
Cr-Commit-Position: refs/heads/master@{#467830}
Committed:
https://chromium.googlesource.com/chromium/src/+/6120633f339b49ea3503dbf86764...
==========

[commit-bot: I haz the power, 2017-04-28 02:04:35]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6120633f339b49ea3503dbf86764...