Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2068813002: Ensure the url provided to a library has a computed hash code (Closed)

Created:
4 years, 6 months ago by Cutch
Modified:
4 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure the url provided to a library has a computed hash code BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/a6aec58b6be9d221dbe0daa10059dafc8f529b54

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M runtime/vm/isolate_reload.cc View 2 chunks +2 lines, -1 line 2 comments Download
M runtime/vm/object.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 6 months ago (2016-06-14 20:52:57 UTC) #3
siva
lgtm https://codereview.chromium.org/2068813002/diff/1/runtime/vm/isolate_reload.cc File runtime/vm/isolate_reload.cc (right): https://codereview.chromium.org/2068813002/diff/1/runtime/vm/isolate_reload.cc#newcode169 runtime/vm/isolate_reload.cc:169: blank line?
4 years, 6 months ago (2016-06-14 21:00:43 UTC) #4
Cutch
https://codereview.chromium.org/2068813002/diff/1/runtime/vm/isolate_reload.cc File runtime/vm/isolate_reload.cc (right): https://codereview.chromium.org/2068813002/diff/1/runtime/vm/isolate_reload.cc#newcode169 runtime/vm/isolate_reload.cc:169: On 2016/06/14 21:00:43, siva wrote: > blank line? Done.
4 years, 6 months ago (2016-06-14 21:27:49 UTC) #5
Cutch
4 years, 6 months ago (2016-06-14 21:28:07 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a6aec58b6be9d221dbe0daa10059dafc8f529b54 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698