Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: runtime/vm/isolate_reload.cc

Issue 2068813002: Ensure the url provided to a library has a computed hash code (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate_reload.cc
diff --git a/runtime/vm/isolate_reload.cc b/runtime/vm/isolate_reload.cc
index e84a99115cb82750c5abddc598ca6ff7e8380987..e2b9d142751523a44e2369d1a46ad7124079eff0 100644
--- a/runtime/vm/isolate_reload.cc
+++ b/runtime/vm/isolate_reload.cc
@@ -166,6 +166,7 @@ bool IsolateReloadContext::IsSameLibrary(
String::Handle(a_lib.IsNull() ? String::null() : a_lib.url());
const String& b_lib_url =
String::Handle(b_lib.IsNull() ? String::null() : b_lib.url());
+
siva 2016/06/14 21:00:43 blank line?
Cutch 2016/06/14 21:27:49 Done.
return a_lib_url.Equals(b_lib_url);
}
@@ -1050,7 +1051,7 @@ RawLibrary* IsolateReloadContext::OldLibraryOrNull(
old_libraries_set(old_libraries_set_storage_);
Library& lib = Library::Handle();
lib ^= old_libraries_set.GetOrNull(replacement_or_new);
- old_libraries_set_storage_ = old_libraries_set.Release().raw();
+ old_libraries_set.Release();
return lib.raw();
}
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698