|
Re-Reland: Make media/capture gn and gyps produce components
The CL is ready but causes a Warning C4267 (implicit size_t to int
conversion) in some Windows Waterfall bots (not in CQ).
After some land-archaeology, it seems that capture.gyp did not
have the warning explicitly disable, I believe it was lost in some
rebase. So, re-enabling it and relanding.
Original re-reland description -----------------------------------------
Re-reland: Make media/capture gn and gyps produce components
Reland got reverted due to a WinX64 typical issue:
warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
This CL adds explicitly some buid/config/compiler/no_size_t_to_int_warning
causing C4267 in
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1472/steps/compile/logs/stdio
Original reland description -------------------------------------------
Reland: Make media/capture gn and gyps produce components
Which got reverted due to a Mac build breakage (see
https://codereview.chromium.org/2059493002/) and
a Win one ( https://crbug.com/618854).
Original description ---------------------------------------------------
Make media/capture gn and gyps produce components
This CL separates media/capture into a component,
to allow, in a subsequent CL, linking with mojo for using
ImageCapture types.
This basically reproduces the media/cast and media/midi
structure.
Windows import/export issues made necessary to add
capture_export and associated CAPTURE_EXPORT macro,
again, replicating media/midi.
gn gen ... --check uncovered some transitive dependencies
during the "analyze" phase of the bots and I had to make
them explicit (e.g. media:gpu).
BUG= 518807
-----------------------------------------------------------------------
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
TBR=avi@chromium.org, xhwang@chromium.org, miu@chromium.org
rationale:
reland: since the PS2/3 are trivial, just making explicit libs that are
already elsewhere in media/ build files- I wonder why it didn't fail in
the bots :( .
re-reland: I'm just adding a MSVS-warning disable that was lost in a
rebase :)
Committed: https://crrev.com/a0f0c4ba5a7fd23448342a879d0a306b441af216
Cr-Commit-Position: refs/heads/master@{#400708}
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+480 lines, -297 lines) |
Patch |
 |
M |
content/browser/BUILD.gn
|
View
|
1
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/common/BUILD.gn
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
content/content_browser.gypi
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/content_common.gypi
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
content/content_tests.gypi
|
View
|
1
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/renderer/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
content/test/BUILD.gn
|
View
|
1
|
3 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
media/BUILD.gn
|
View
|
1
|
5 chunks |
+7 lines, -9 lines |
0 comments
|
Download
|
 |
M |
media/base/BUILD.gn
|
View
|
1
|
1 chunk |
+8 lines, -0 lines |
0 comments
|
Download
|
 |
M |
media/base/win/BUILD.gn
|
View
|
|
1 chunk |
+15 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/base/win/mf_initializer.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
A |
media/base/win/mf_initializer_export.h
|
View
|
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
 |
M |
media/capture/BUILD.gn
|
View
|
|
6 chunks |
+28 lines, -17 lines |
0 comments
|
Download
|
 |
A |
media/capture/capture.gyp
|
View
|
1
|
1 chunk |
+225 lines, -0 lines |
0 comments
|
Download
|
 |
D |
media/capture/capture.gypi
|
View
|
|
1 chunk |
+0 lines, -106 lines |
0 comments
|
Download
|
 |
A |
media/capture/capture_export.h
|
View
|
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
 |
M |
media/capture/content/animated_content_sampler.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/capture/content/capture_resolution_chooser.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/capture/content/feedback_signal_accumulator.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/capture/content/screen_capture_device_core.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
media/capture/content/smooth_event_sampler.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/capture/content/thread_safe_capture_oracle.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/capture/content/thread_safe_capture_oracle.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/capture/content/video_capture_oracle.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/capture/device_monitor_mac.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/capture/device_monitor_udev.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/capture/system_message_window_win.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/capture/video/android/BUILD.gn
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
media/capture/video/android/capture_jni_registrar.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/capture/video/android/video_capture_device_android.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/capture/video/android/video_capture_device_factory_android.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/capture/video/fake_video_capture_device.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/capture/video/fake_video_capture_device.cc
|
View
|
|
2 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/capture/video/fake_video_capture_device_factory.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/capture/video/file_video_capture_device.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/capture/video/file_video_capture_device.cc
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/capture/video/file_video_capture_device_factory.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/capture/video/linux/video_capture_device_factory_linux.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/capture/video/mac/video_capture_device_decklink_mac.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/capture/video/mac/video_capture_device_factory_mac.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/capture/video/mac/video_capture_device_mac.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/capture/video/video_capture_device.h
|
View
|
1
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
media/capture/video/video_capture_device_factory.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/capture/video/video_capture_device_info.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/capture/video/win/filter_base_win.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
1 comment
|
Download
|
 |
M |
media/capture/video/win/video_capture_device_factory_win.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/capture/video/win/video_capture_device_factory_win.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
media/capture/video/win/video_capture_device_mf_win.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
media/cast/cast.gyp
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
media/gpu/BUILD.gn
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
media/media.gyp
|
View
|
1
|
16 chunks |
+55 lines, -104 lines |
0 comments
|
Download
|
 |
M |
media/media_gpu.gypi
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
Total messages: 17 (10 generated)
|