media/capture/video/win/filter_base_win.cc - Issue 2068763002: Re-Reland: Make media/capture gn and gyps produce components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/win/filter_base_win.cc

Issue 2068763002: Re-Reland: Make media/capture gn and gyps produce components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable warning 4267 in Win capture.gyp (probs. lost in the previous relanding). Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/capture/video/win/filter_base_win.cc

diff --git a/media/capture/video/win/filter_base_win.cc b/media/capture/video/win/filter_base_win.cc

index 166b8600146d49abfc541d18871142eba162adb7..c43ec64bf11b8bef8de26a71503686d171c0eec2 100644

--- a/media/capture/video/win/filter_base_win.cc

+++ b/media/capture/video/win/filter_base_win.cc

@@ -38,7 +38,8 @@ class PinEnumerator final : public IEnumPins,

STDMETHOD(Next)(ULONG count, IPin** pins, ULONG* fetched) override {

ULONG pins_fetched = 0;

while (pins_fetched < count && filter_->NoOfPins() > index_) {

- IPin* pin = filter_->GetPin(index_++);

+ index_++;

+ IPin* pin = filter_->GetPin(static_cast<int>(index_));

emircan 2016/06/21 04:54:36 This would pre-increment and cause a different beh

pin->AddRef();

pins[pins_fetched++] = pin;

}

« no previous file with comments | « media/capture/video/video_capture_device_info.h ('k') | media/capture/video/win/video_capture_device_factory_win.h » ('j') | no next file with comments »