Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2068743003:
Keep SkColorSpace and SkColorProfileType in sync (Closed)
DescriptionKeep SkColorSpace and SkColorProfileType in sync
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2068743003
Committed: https://skia.googlesource.com/skia/+/04d35bd80dde7cace866781037cbbdcab14ab683
Committed: https://skia.googlesource.com/skia/+/ded0f26a93a115fdb8f2eb99841b85cc16baf400
Patch Set 1 #Patch Set 2 : Fix test #Patch Set 3 : Fix roll using SK_API #
Depends on Patchset: Messages
Total messages: 27 (14 generated)
Description was changed from ========== Keep SkColorSpace and SkColorProfileType in sync BUG=skia: ========== to ========== Keep SkColorSpace and SkColorProfileType in sync BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2068743003 ==========
msarett@google.com changed reviewers: + brianosman@google.com, reed@google.com
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068743003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
lgtm, but I'd rather see us starting to eliminate the bloody enum entirely. Are we far from that?
On 2016/06/15 15:32:42, reed1 wrote: > lgtm, but I'd rather see us starting to eliminate the bloody enum entirely. Are > we far from that? Umm I think yes, though TBH I haven't really tried hard enough to be sure.
msarett@google.com changed reviewers: + herb@google.com
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068743003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msarett@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com Link to the patchset: https://codereview.chromium.org/2068743003/#ps20001 (title: "Fix test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068743003/20001
Message was sent while issue was closed.
Description was changed from ========== Keep SkColorSpace and SkColorProfileType in sync BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2068743003 ========== to ========== Keep SkColorSpace and SkColorProfileType in sync BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2068743003 Committed: https://skia.googlesource.com/skia/+/04d35bd80dde7cace866781037cbbdcab14ab683 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/04d35bd80dde7cace866781037cbbdcab14ab683
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2073593002/ by egdaniel@google.com. The reason for reverting is: breaking roll. ../../third_party/skia/include/core/SkImageInfo.h:202: error: undefined reference to 'SkColorSpace::NewNamed(SkColorSpace::Named)' .
Message was sent while issue was closed.
Description was changed from ========== Keep SkColorSpace and SkColorProfileType in sync BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2068743003 Committed: https://skia.googlesource.com/skia/+/04d35bd80dde7cace866781037cbbdcab14ab683 ========== to ========== Keep SkColorSpace and SkColorProfileType in sync BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2068743003 Committed: https://skia.googlesource.com/skia/+/04d35bd80dde7cace866781037cbbdcab14ab683 ==========
The CQ bit was checked by msarett@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com Link to the patchset: https://codereview.chromium.org/2068743003/#ps40001 (title: "Fix roll using SK_API")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068743003/40001
Message was sent while issue was closed.
Description was changed from ========== Keep SkColorSpace and SkColorProfileType in sync BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2068743003 Committed: https://skia.googlesource.com/skia/+/04d35bd80dde7cace866781037cbbdcab14ab683 ========== to ========== Keep SkColorSpace and SkColorProfileType in sync BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2068743003 Committed: https://skia.googlesource.com/skia/+/04d35bd80dde7cace866781037cbbdcab14ab683 Committed: https://skia.googlesource.com/skia/+/ded0f26a93a115fdb8f2eb99841b85cc16baf400 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/ded0f26a93a115fdb8f2eb99841b85cc16baf400 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
