Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 206873006: [GCM] Add port 443 fallback logic and histograms (Closed)

Created:
6 years, 9 months ago by Nicolas Zea
Modified:
6 years, 9 months ago
CC:
chromium-reviews, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

[GCM] Add port 443 fallback logic and histograms Alternate between the default (5228) endpoint and the fallback (443) endpoint. Also introduce histograms for tracking endpoint and proxy success rate. Relanding due to compile issue. Original review: https://codereview.chromium.org/205343003/ BUG=351890 TBR=jianli@chromium.org, fgorski@chromium.org, asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258997

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -15 lines) Patch
M google_apis/gcm/engine/connection_factory_impl.h View 3 chunks +12 lines, -3 lines 0 comments Download
M google_apis/gcm/engine/connection_factory_impl.cc View 6 chunks +31 lines, -5 lines 0 comments Download
M google_apis/gcm/engine/connection_factory_impl_unittest.cc View 5 chunks +13 lines, -2 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 9 months ago (2014-03-24 17:57:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/206873006/1
6 years, 9 months ago (2014-03-24 17:58:22 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 19:17:13 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 9 months ago (2014-03-24 19:17:13 UTC) #4
Nicolas Zea
Committed patchset #1 manually as r258997 (presubmit successful).
6 years, 9 months ago (2014-03-24 19:48:30 UTC) #5
fgorski
6 years, 9 months ago (2014-03-24 23:17:32 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698