Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 206873006: [GCM] Add port 443 fallback logic and histograms (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « google_apis/gcm/tools/mcs_probe.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index dae8f94371fee10d15f2c4ac27438792842781ed..7f7725f8bd10ce4f9ccd519f7f4e0e4b017ab2a2 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -6578,11 +6578,21 @@ other types of suffix sets.
<summary>Status code of the outcome of a GCM checkin request.</summary>
</histogram>
+<histogram name="GCM.ConnectedViaProxy" enum="Boolean">
+ <owner>zea@chromium.org</owner>
+ <summary>Whether the GCM connection was made via a proxy or not.</summary>
+</histogram>
+
<histogram name="GCM.ConnectionDisconnectErrorCode" enum="NetErrorCodes">
<owner>zea@chromium.org</owner>
<summary>Net error results from GCM disconnect events.</summary>
</histogram>
+<histogram name="GCM.ConnectionEndpoint" enum="GCMEndpoints">
+ <owner>zea@chromium.org</owner>
+ <summary>Number of connections made to each specific MCS endpoint.</summary>
+</histogram>
+
<histogram name="GCM.ConnectionFailureErrorCode" enum="NetErrorCodes">
<owner>zea@chromium.org</owner>
<summary>Net error results from GCM connection attempts.</summary>
@@ -6593,7 +6603,7 @@ other types of suffix sets.
<summary>Reasons for GCM connection resets.</summary>
</histogram>
-<histogram name="GCM.ConnectionSuccessRate">
+<histogram name="GCM.ConnectionSuccessRate" enum="BooleanSuccess">
<owner>zea@chromium.org</owner>
<summary>
GCM connection success rate. Does not take into account login success. See
@@ -32652,6 +32662,11 @@ other types of suffix sets.
<int value="3" label="Socket failure"/>
</enum>
+<enum name="GCMEndpoints" type="int">
+ <int value="0" label="mtalk.google.com:5228"/>
+ <int value="1" label="mtalk.google.com:443"/>
+</enum>
+
<enum name="GCMInvalidationsIncomingMessageStatus" type="int">
<int value="0" label="Success"/>
<int value="1" label="GCM message's content missing or empty"/>
« no previous file with comments | « google_apis/gcm/tools/mcs_probe.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698