Refactors profile avatar selector into a Polymer element to use in md-settings & md-user-manager

chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc

Index: chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
diff --git a/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc b/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
index 7a51417d4e3ab8b4cc1951086673408bef99ff0d..1f9683c5c8f68cc70eae3459b366db18600f08d5 100644
--- a/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
+++ b/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
@@ -107,16 +107,29 @@ std::unique_ptr<base::ListValue> ManageProfileHandler::GetAvailableIcons() {
           GetProfileAttributesWithPath(profile_->GetPath(), &entry)) {
     const gfx::Image* icon = entry->GetGAIAPicture();
     if (icon) {
+      std::unique_ptr<base::DictionaryValue> gaia_picture_info(
+          new base::DictionaryValue());
       gfx::Image icon2 = profiles::GetAvatarIconForWebUI(*icon, true);
       gaia_picture_url_ = webui::GetBitmapDataUrl(icon2.AsBitmap());
-      image_url_list->AppendString(gaia_picture_url_);
+      gaia_picture_info->SetString("url", gaia_picture_url_);
+      // TODO(tommycli): what is the right label for the gaia picture?
+      gaia_picture_info->SetString("label", std::string());

[tommycli, 2016/06/14 23:50:59]

It seems like maybe it's an empty string?
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/options/manage_p...

However, Ideally I think it should be a localized version of "Profile Image".

Do we already have such a localized string we could set it as? 

[Moe, 2016/06/15 19:35:00]

There's already a localized string for changing the profile picture in cros:
IDS_SETTINGS_CHANGE_PICTURE_PROFILE_PHOTO
I went ahead and reused that here. It says "Google Profile photo". I chatted
with ewald@ and he's on board with that.

[tommycli, 2016/06/15 19:59:47]

Excellent. Thanks for looking into it.

+      image_url_list->Append(std::move(gaia_picture_info));
     }
   }
 
   // Next add the default avatar icons and names.
-  for (size_t i = 0; i < profiles::GetDefaultAvatarIconCount(); i++) {
-    std::string url = profiles::GetDefaultAvatarIconUrl(i);
-    image_url_list->AppendString(url);
+  size_t placeholder_avatar_index = profiles::GetPlaceholderAvatarIndex();
+  for (size_t i = 0; i < profiles::GetDefaultAvatarIconCount() &&
+                     i != placeholder_avatar_index;
+       i++) {
+    std::unique_ptr<base::DictionaryValue> avatar_info(
+        new base::DictionaryValue());
+    avatar_info->SetString("url", profiles::GetDefaultAvatarIconUrl(i));
+    avatar_info->SetString(
+        "label", l10n_util::GetStringUTF16(
+                     profiles::GetDefaultAvatarLabelResourceIDAtIndex(i)));
+    image_url_list->Append(std::move(avatar_info));
   }
 
   return image_url_list;