Refactors profile avatar selector into a Polymer element to use in md-settings & md-user-manager

chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/settings_manage_profile_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 80 matching lines @@
   AllowJavascript();
 
   profiles::UpdateGaiaProfileInfoIfNeeded(profile_);
 
   CHECK_EQ(1U, args->GetSize());
   const base::Value* callback_id;
   CHECK(args->Get(0, &callback_id));
   ResolveJavascriptCallback(*callback_id, *GetAvailableIcons());
 }
 
 std::unique_ptr<base::ListValue> ManageProfileHandler::GetAvailableIcons() {

[tommycli, 2016/06/14 23:50:59]

I noticed that you're updating this to be very similar to
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/signin/signin_cr...

Can we dedupe the code a bit / share logic? Could we even move the
getAvailableIcons mechanism to be within the selector element? That could be in
a followup patch if necessary.

[Moe, 2016/06/15 19:35:00]

i think we should refactor getting the default avatar icons and labels. and the
maybe you can only add gaia profile picture to the beginning of the list if it's
available. Let's do that in a follow up CL.
As for moving the getAvailableIcons mechanism to the element itself, I don't
know how that can be combined with the browser proxy approach. We can discuss
that though. 

[tommycli, 2016/06/15 19:59:47]

Sounds good I'm okay with doing that refactor in a followup.

   std::unique_ptr<base::ListValue> image_url_list(new base::ListValue());
 
   // First add the GAIA picture if it is available.
   ProfileAttributesEntry* entry;
   if (g_browser_process->profile_manager()->GetProfileAttributesStorage().
           GetProfileAttributesWithPath(profile_->GetPath(), &entry)) {
     const gfx::Image* icon = entry->GetGAIAPicture();
     if (icon) {
+      std::unique_ptr<base::DictionaryValue> gaia_picture_info(
+          new base::DictionaryValue());
       gfx::Image icon2 = profiles::GetAvatarIconForWebUI(*icon, true);
       gaia_picture_url_ = webui::GetBitmapDataUrl(icon2.AsBitmap());
-      image_url_list->AppendString(gaia_picture_url_);
+      gaia_picture_info->SetString("url", gaia_picture_url_);
+      // TODO(tommycli): what is the right label for the gaia picture?
+      gaia_picture_info->SetString("label", std::string());

[tommycli, 2016/06/14 23:50:59]

It seems like maybe it's an empty string?
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/options/manage_p...

However, Ideally I think it should be a localized version of "Profile Image".

Do we already have such a localized string we could set it as? 

[Moe, 2016/06/15 19:35:00]

There's already a localized string for changing the profile picture in cros:
IDS_SETTINGS_CHANGE_PICTURE_PROFILE_PHOTO
I went ahead and reused that here. It says "Google Profile photo". I chatted
with ewald@ and he's on board with that.

[tommycli, 2016/06/15 19:59:47]

Excellent. Thanks for looking into it.

+      image_url_list->Append(std::move(gaia_picture_info));
     }
   }
 
   // Next add the default avatar icons and names.
-  for (size_t i = 0; i < profiles::GetDefaultAvatarIconCount(); i++) {
-    std::string url = profiles::GetDefaultAvatarIconUrl(i);
-    image_url_list->AppendString(url);
+  size_t placeholder_avatar_index = profiles::GetPlaceholderAvatarIndex();
+  for (size_t i = 0; i < profiles::GetDefaultAvatarIconCount() &&
+                     i != placeholder_avatar_index;
+       i++) {
+    std::unique_ptr<base::DictionaryValue> avatar_info(
+        new base::DictionaryValue());
+    avatar_info->SetString("url", profiles::GetDefaultAvatarIconUrl(i));
+    avatar_info->SetString(
+        "label", l10n_util::GetStringUTF16(
+                     profiles::GetDefaultAvatarLabelResourceIDAtIndex(i)));
+    image_url_list->Append(std::move(avatar_info));
   }
 
   return image_url_list;
 }
 
 void ManageProfileHandler::HandleSetProfileIconAndName(
     const base::ListValue* args) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   DCHECK(args);
   DCHECK_EQ(2u, args->GetSize());
@@ skipping 91 matching lines @@
     g_browser_process->profile_manager()->profile_shortcut_manager();
   DCHECK(shortcut_manager);
 
   shortcut_manager->RemoveProfileShortcuts(profile_->GetPath());
 
   // Update the UI buttons.
   OnHasProfileShortcuts(false);
 }
 
 }  // namespace settings