Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2068633003: Revert of Adding mac support for Remoting host GN builds. (Closed)

Created:
4 years, 6 months ago by hcarmona
Modified:
4 years, 6 months ago
Reviewers:
Sergey Ulanov, nicholss
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding mac support for Remoting host GN builds. (patchset #6 id:100001 of https://codereview.chromium.org/2034513002/ ) Reason for revert: Suspecting this CL for compile failure in Mac GN: https://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/34015 Undefined symbols for architecture x86_64: "_GetApplicationEventTarget", referenced from: remoting::(anonymous namespace)::SessionWatcher::InstallEventHandler() in libhost.a(curtain_mode_mac.o) "_InstallEventHandler", referenced from: remoting::(anonymous namespace)::SessionWatcher::InstallEventHandler() in libhost.a(curtain_mode_mac.o) "_RemoveEventHandler", referenced from: remoting::(anonymous namespace)::SessionWatcher::RemoveEventHandler() in libhost.a(curtain_mode_mac.o) ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) Original issue's description: > Adding mac support for Remoting host GN builds. > > BUG=611859 > > R=sergeyu@chromium.org > > Committed: https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5 > Cr-Commit-Position: refs/heads/master@{#399731} TBR=sergeyu@chromium.org,nicholss@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=611859 Committed: https://crrev.com/9fe48917bcb24d199b3e008566057f59856f1ac4 Cr-Commit-Position: refs/heads/master@{#399742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1163 lines, -1161 lines) Patch
M remoting/BUILD.gn View 3 chunks +87 lines, -82 lines 0 comments Download
M remoting/host/BUILD.gn View 3 chunks +1052 lines, -1038 lines 0 comments Download
M remoting/host/constants_mac.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D remoting/host/version.h.in View 1 chunk +0 lines, -20 lines 0 comments Download
M remoting/remoting_enable.gni View 1 chunk +8 lines, -1 line 0 comments Download
M remoting/remoting_version.gni View 1 chunk +16 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hcarmona
Created Revert of Adding mac support for Remoting host GN builds.
4 years, 6 months ago (2016-06-14 17:52:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068633003/1
4 years, 6 months ago (2016-06-14 17:53:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 17:54:11 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 17:57:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fe48917bcb24d199b3e008566057f59856f1ac4
Cr-Commit-Position: refs/heads/master@{#399742}

Powered by Google App Engine
This is Rietveld 408576698