Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: remoting/remoting_version.gni

Issue 2068633003: Revert of Adding mac support for Remoting host GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/remoting_enable.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/remoting_version.gni
diff --git a/remoting/remoting_version.gni b/remoting/remoting_version.gni
index cdf97fa98f469463092048352be1f183807176fa..ac96c9ebf377b038b8e9fecb4beda00be0d8218e 100644
--- a/remoting/remoting_version.gni
+++ b/remoting/remoting_version.gni
@@ -23,20 +23,20 @@
_remoting_branding_path =
rebase_path(_remoting_branding_abspath, root_build_dir)
-_branding_dictionary_template = "mac_host_bundle = \"@MAC_HOST_BUNDLE_NAME@\" " + "mac_native_messaging_bundle = \"@MAC_NATIVE_MESSAGING_HOST_BUNDLE_NAME@\" " + "mac_remote_assistance_bundle = \"@MAC_REMOTE_ASSISTANCE_HOST_BUNDLE_NAME@\" " + "prefpane_bundle_name = \"@MAC_PREFPANE_BUNDLE_NAME@\" " + "host_bundle_name = \"@MAC_HOST_BUNDLE_NAME@\" "
+prefpane_bundle_name = exec_script(_version_py_abspath,
+ [
+ "-f",
+ _remoting_branding_path,
+ "-t \"@MAC_PREFPANE_BUNDLE_NAME@\"",
+ ],
+ "string",
+ remoting_version_files)
-_result = exec_script(_version_py_abspath,
- [
- "-f",
- _remoting_branding_path,
- "-t",
- _branding_dictionary_template,
- ],
- "scope",
- remoting_version_files)
-
-prefpane_bundle_name = _result.prefpane_bundle_name
-host_bundle_name = _result.host_bundle_name
-me2me_host_bundle_name = _result.mac_host_bundle
-native_messaging_host_bundle_name = _result.mac_native_messaging_bundle
-remote_assistance_host_bundle_name = _result.mac_remote_assistance_bundle
+host_bundle_name = exec_script(_version_py_abspath,
+ [
+ "-f",
+ _remoting_branding_path,
+ "-t \"@MAC_HOST_BUNDLE_NAME@\"",
+ ],
+ "string",
+ remoting_version_files)
« no previous file with comments | « remoting/remoting_enable.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698