Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2068333002: Disable the deprecated Alt+Shift for NEXT_IME (Closed)

Created:
4 years, 6 months ago by afakhry
Modified:
4 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable the deprecated Alt+Shift for NEXT_IME Due to its many conflicts, we decided to remove it for M-53. We will keep the notification so as not to confuse users. R=oshima@chromium.org BUG=612990, 593633 TEST=ash_unittests --gtest_filter=DeprecatedAcceleratorTester.* TEST=ash_unittests --gtest_filter=AcceleratorControllerTest.* Committed: https://crrev.com/25174475a4ad63208a3dfc0755b4ced719ac2dfd Cr-Commit-Position: refs/heads/master@{#400245}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removing the old accelerators entirely. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -256 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 3 chunks +34 lines, -48 lines 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 1 2 chunks +35 lines, -195 lines 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 3 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
afakhry
Oshima, please review. Thanks!
4 years, 6 months ago (2016-06-15 20:38:40 UTC) #3
oshima
https://codereview.chromium.org/2068333002/diff/40001/ash/accelerators/accelerator_controller.cc File ash/accelerators/accelerator_controller.cc (right): https://codereview.chromium.org/2068333002/diff/40001/ash/accelerators/accelerator_controller.cc#newcode308 ash/accelerators/accelerator_controller.cc:308: // Non-chromeos platforms still use the old NEXT_IME shortcuts. ...
4 years, 6 months ago (2016-06-15 21:13:25 UTC) #4
afakhry
https://codereview.chromium.org/2068333002/diff/40001/ash/accelerators/accelerator_controller.cc File ash/accelerators/accelerator_controller.cc (right): https://codereview.chromium.org/2068333002/diff/40001/ash/accelerators/accelerator_controller.cc#newcode308 ash/accelerators/accelerator_controller.cc:308: // Non-chromeos platforms still use the old NEXT_IME shortcuts. ...
4 years, 6 months ago (2016-06-16 18:40:49 UTC) #5
oshima
lgtm
4 years, 6 months ago (2016-06-16 19:07:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068333002/60001
4 years, 6 months ago (2016-06-16 19:20:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 6 months ago (2016-06-16 20:14:56 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 20:16:41 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25174475a4ad63208a3dfc0755b4ced719ac2dfd
Cr-Commit-Position: refs/heads/master@{#400245}

Powered by Google App Engine
This is Rietveld 408576698