Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Side by Side Diff: ash/accelerators/accelerator_table.cc

Issue 2068333002: Disable the deprecated Alt+Shift for NEXT_IME (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing the old accelerators entirely. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/accelerators/accelerator_controller_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/accelerators/accelerator_table.h" 5 #include "ash/accelerators/accelerator_table.h"
6 6
7 #include "ash/strings/grit/ash_strings.h" 7 #include "ash/strings/grit/ash_strings.h"
8 #include "base/macros.h" 8 #include "base/macros.h"
9 9
10 namespace ash { 10 namespace ash {
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 { true, ui::VKEY_VOLUME_MUTE, ui::EF_NONE, VOLUME_MUTE }, 91 { true, ui::VKEY_VOLUME_MUTE, ui::EF_NONE, VOLUME_MUTE },
92 { true, ui::VKEY_VOLUME_DOWN, ui::EF_NONE, VOLUME_DOWN }, 92 { true, ui::VKEY_VOLUME_DOWN, ui::EF_NONE, VOLUME_DOWN },
93 { true, ui::VKEY_VOLUME_UP, ui::EF_NONE, VOLUME_UP }, 93 { true, ui::VKEY_VOLUME_UP, ui::EF_NONE, VOLUME_UP },
94 { true, ui::VKEY_ESCAPE, ui::EF_COMMAND_DOWN, SHOW_TASK_MANAGER }, 94 { true, ui::VKEY_ESCAPE, ui::EF_COMMAND_DOWN, SHOW_TASK_MANAGER },
95 { true, ui::VKEY_SPACE, ui::EF_CONTROL_DOWN | ui::EF_SHIFT_DOWN, NEXT_IME }, 95 { true, ui::VKEY_SPACE, ui::EF_CONTROL_DOWN | ui::EF_SHIFT_DOWN, NEXT_IME },
96 #else 96 #else
97 // This key has been deprecated on CrOS. It is instead included below in the 97 // This key has been deprecated on CrOS. It is instead included below in the
98 // |kDeprecatedAccelerators|, and above in the CrOS accelerators as 98 // |kDeprecatedAccelerators|, and above in the CrOS accelerators as
99 // Search+Esc. 99 // Search+Esc.
100 { true, ui::VKEY_ESCAPE, ui::EF_SHIFT_DOWN, SHOW_TASK_MANAGER }, 100 { true, ui::VKEY_ESCAPE, ui::EF_SHIFT_DOWN, SHOW_TASK_MANAGER },
101 // The below keys have been deprecated on ChromeOS and were replaced above by
102 // Ctrl+Shift+Space. crbug.com/535004.
103 // We have to define 3 entries for Shift+Alt. VKEY_[LR]MENU might be sent to
104 // the accelerator controller when RenderWidgetHostViewAura is focused, and
105 // VKEY_MENU might be when it's not (e.g. when NativeWidgetAura is focused).
106 { false, ui::VKEY_LMENU, ui::EF_SHIFT_DOWN, NEXT_IME },
107 { false, ui::VKEY_MENU, ui::EF_SHIFT_DOWN, NEXT_IME },
108 { false, ui::VKEY_RMENU, ui::EF_SHIFT_DOWN, NEXT_IME },
109 // The same is true for Alt+Shift.
110 { false, ui::VKEY_LSHIFT, ui::EF_ALT_DOWN, NEXT_IME },
111 { false, ui::VKEY_SHIFT, ui::EF_ALT_DOWN, NEXT_IME },
112 { false, ui::VKEY_RSHIFT, ui::EF_ALT_DOWN, NEXT_IME },
113 #endif // defined(OS_CHROMEOS) 101 #endif // defined(OS_CHROMEOS)
114 { true, ui::VKEY_I, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN, OPEN_FEEDBACK_PAGE }, 102 { true, ui::VKEY_I, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN, OPEN_FEEDBACK_PAGE },
115 #if !defined(OS_WIN) 103 #if !defined(OS_WIN)
116 { true, ui::VKEY_Q, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, EXIT }, 104 { true, ui::VKEY_Q, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, EXIT },
117 #endif 105 #endif
118 { true, ui::VKEY_N, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, 106 { true, ui::VKEY_N, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
119 NEW_INCOGNITO_WINDOW }, 107 NEW_INCOGNITO_WINDOW },
120 { true, ui::VKEY_N, ui::EF_CONTROL_DOWN, NEW_WINDOW }, 108 { true, ui::VKEY_N, ui::EF_CONTROL_DOWN, NEW_WINDOW },
121 { true, ui::VKEY_T, ui::EF_CONTROL_DOWN, NEW_TAB }, 109 { true, ui::VKEY_T, ui::EF_CONTROL_DOWN, NEW_TAB },
122 { true, ui::VKEY_OEM_MINUS, 110 { true, ui::VKEY_OEM_MINUS,
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 IDS_SHORTCUT_TASK_MANAGER_OLD, 227 IDS_SHORTCUT_TASK_MANAGER_OLD,
240 IDS_SHORTCUT_TASK_MANAGER_NEW, 228 IDS_SHORTCUT_TASK_MANAGER_NEW,
241 true 229 true
242 }, 230 },
243 { 231 {
244 NEXT_IME, 232 NEXT_IME,
245 "Ash.Accelerators.Deprecated.NextIME", 233 "Ash.Accelerators.Deprecated.NextIME",
246 IDS_DEPRECATED_NEXT_IME_MSG, 234 IDS_DEPRECATED_NEXT_IME_MSG,
247 IDS_SHORTCUT_NEXT_IME_OLD, 235 IDS_SHORTCUT_NEXT_IME_OLD,
248 IDS_SHORTCUT_NEXT_IME_NEW, 236 IDS_SHORTCUT_NEXT_IME_NEW,
249 true 237 false // Old accelerator has been disabled.
250 } 238 }
251 }; 239 };
252 240
253 const size_t kDeprecatedAcceleratorsDataLength = 241 const size_t kDeprecatedAcceleratorsDataLength =
254 arraysize(kDeprecatedAcceleratorsData); 242 arraysize(kDeprecatedAcceleratorsData);
255 243
256 #endif // defined(OS_CHROMEOS) 244 #endif // defined(OS_CHROMEOS)
257 245
258 const AcceleratorData kDebugAcceleratorData[] = { 246 const AcceleratorData kDebugAcceleratorData[] = {
259 #if defined(OS_CHROMEOS) 247 #if defined(OS_CHROMEOS)
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 }; 430 };
443 431
444 const size_t kActionsAllowedAtModalWindowLength = 432 const size_t kActionsAllowedAtModalWindowLength =
445 arraysize(kActionsAllowedAtModalWindow); 433 arraysize(kActionsAllowedAtModalWindow);
446 434
447 const AcceleratorAction kNonrepeatableActions[] = { 435 const AcceleratorAction kNonrepeatableActions[] = {
448 // TODO(mazda): Add other actions which should not be repeated. 436 // TODO(mazda): Add other actions which should not be repeated.
449 CYCLE_BACKWARD_MRU, 437 CYCLE_BACKWARD_MRU,
450 CYCLE_FORWARD_MRU, 438 CYCLE_FORWARD_MRU,
451 EXIT, 439 EXIT,
440 NEXT_IME,
441 PREVIOUS_IME,
452 OPEN_FEEDBACK_PAGE, 442 OPEN_FEEDBACK_PAGE,
453 PRINT_UI_HIERARCHIES, // Don't fill the logs if the key is held down. 443 PRINT_UI_HIERARCHIES, // Don't fill the logs if the key is held down.
454 ROTATE_SCREEN, 444 ROTATE_SCREEN,
455 ROTATE_WINDOW, 445 ROTATE_WINDOW,
456 SCALE_UI_UP, 446 SCALE_UI_UP,
457 SCALE_UI_DOWN, 447 SCALE_UI_DOWN,
458 SCALE_UI_RESET, 448 SCALE_UI_RESET,
459 TAKE_WINDOW_SCREENSHOT, 449 TAKE_WINDOW_SCREENSHOT,
460 TAKE_PARTIAL_SCREENSHOT, 450 TAKE_PARTIAL_SCREENSHOT,
461 TAKE_SCREENSHOT, 451 TAKE_SCREENSHOT,
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
557 TOGGLE_WIFI, 547 TOGGLE_WIFI,
558 VOLUME_DOWN, 548 VOLUME_DOWN,
559 VOLUME_MUTE, 549 VOLUME_MUTE,
560 VOLUME_UP, 550 VOLUME_UP,
561 #endif // defined(OS_CHROMEOS) 551 #endif // defined(OS_CHROMEOS)
562 }; 552 };
563 553
564 const size_t kActionsKeepingMenuOpenLength = arraysize(kActionsKeepingMenuOpen); 554 const size_t kActionsKeepingMenuOpenLength = arraysize(kActionsKeepingMenuOpen);
565 555
566 } // namespace ash 556 } // namespace ash
OLDNEW
« no previous file with comments | « ash/accelerators/accelerator_controller_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698