Source/core/editing/ReplaceSelectionCommand.cpp - Issue 20681004: Make first-letter style to work with editing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ReplaceSelectionCommand.cpp

Issue 20681004: Make first-letter style to work with editing Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: 2013-08-01T17:57:42 Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/editing/InsertParagraphSeparatorCommand.cpp ('k') | Source/core/editing/TextIterator.cpp » ('j') | Source/core/rendering/RenderText.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/ReplaceSelectionCommand.cpp

diff --git a/Source/core/editing/ReplaceSelectionCommand.cpp b/Source/core/editing/ReplaceSelectionCommand.cpp

index 563995666cfccfe6f6319ae02fcfd19e63e5d57a..89bdcdaa1f6cb62cd3b1a19c9db7fcd850ad9ef1 100644

--- a/Source/core/editing/ReplaceSelectionCommand.cpp

+++ b/Source/core/editing/ReplaceSelectionCommand.cpp

@@ -895,8 +895,8 @@ void ReplaceSelectionCommand::doApply()

return;

// We can skip matching the style if the selection is plain text.

- if ((selection.start().deprecatedNode()->renderer() && selection.start().deprecatedNode()->renderer()->style()->userModify() == READ_WRITE_PLAINTEXT_ONLY)

- && (selection.end().deprecatedNode()->renderer() && selection.end().deprecatedNode()->renderer()->style()->userModify() == READ_WRITE_PLAINTEXT_ONLY))

+ if ((selection.start().renderer() && selection.start().renderer()->style()->userModify() == READ_WRITE_PLAINTEXT_ONLY)

+ && (selection.end().renderer() && selection.end().renderer()->style()->userModify() == READ_WRITE_PLAINTEXT_ONLY))

m_matchStyle = false;

if (m_matchStyle) {

« no previous file with comments | « Source/core/editing/InsertParagraphSeparatorCommand.cpp ('k') | Source/core/editing/TextIterator.cpp » ('j') | Source/core/rendering/RenderText.cpp » ('J')