Source/core/editing/InsertParagraphSeparatorCommand.cpp - Issue 20681004: Make first-letter style to work with editing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/InsertParagraphSeparatorCommand.cpp

Issue 20681004: Make first-letter style to work with editing Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: 2013-08-01T17:57:42 Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/editing/InsertLineBreakCommand.cpp ('k') | Source/core/editing/ReplaceSelectionCommand.cpp » ('j') | Source/core/rendering/RenderText.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/InsertParagraphSeparatorCommand.cpp

diff --git a/Source/core/editing/InsertParagraphSeparatorCommand.cpp b/Source/core/editing/InsertParagraphSeparatorCommand.cpp

index 84f830e69e159cc000f8163e8cdea30e2be0351b..4958bf559f6b932b58e92ec13c36ed673645210a 100644

--- a/Source/core/editing/InsertParagraphSeparatorCommand.cpp

+++ b/Source/core/editing/InsertParagraphSeparatorCommand.cpp

@@ -170,7 +170,7 @@ void InsertParagraphSeparatorCommand::doApply()

|| isTableCell(startBlock.get())

|| startBlock->hasTagName(formTag)

// FIXME: If the node is hidden, we don't have a canonical position so we will do the wrong thing for tables and <hr>. https://bugs.webkit.org/show_bug.cgi?id=40342

- || (!canonicalPos.isNull() && canonicalPos.deprecatedNode()->renderer() && canonicalPos.deprecatedNode()->renderer()->isTable())

+ || (!canonicalPos.isNull() && canonicalPos.renderer() && canonicalPos.renderer()->isTable())

|| (!canonicalPos.isNull() && canonicalPos.deprecatedNode()->hasTagName(hrTag))) {

applyCommandToComposite(InsertLineBreakCommand::create(document()));

return;

« no previous file with comments | « Source/core/editing/InsertLineBreakCommand.cpp ('k') | Source/core/editing/ReplaceSelectionCommand.cpp » ('j') | Source/core/rendering/RenderText.cpp » ('J')