Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2068003002: dart2js: allow trailing commas in parameter and argument lists (Closed)

Created:
4 years, 6 months ago by Harry Terkelsen
Modified:
4 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : fix test #

Patch Set 4 : fix status file #

Total comments: 3

Patch Set 5 : respond to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -14 lines) Patch
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 2 3 4 2 chunks +33 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/parser.dart View 1 2 3 4 3 chunks +20 lines, -5 lines 0 comments Download
M tests/compiler/dart2js_extra/invalid_annotation2_test.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/invalid_annotation_test.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tests/language/arg_param_trailing_comma_test.dart View 1 2 3 4 6 chunks +166 lines, -5 lines 0 comments Download
M tests/language/language.status View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Harry Terkelsen
4 years, 5 months ago (2016-07-08 01:43:39 UTC) #2
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/2068003002/diff/60001/pkg/compiler/lib/src/parser/parser.dart File pkg/compiler/lib/src/parser/parser.dart (right): https://codereview.chromium.org/2068003002/diff/60001/pkg/compiler/lib/src/parser/parser.dart#newcode430 pkg/compiler/lib/src/parser/parser.dart:430: } Is this `if` necessary now? https://codereview.chromium.org/2068003002/diff/60001/tests/language/arg_param_trailing_comma_test.dart File ...
4 years, 5 months ago (2016-07-08 05:45:18 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/2068003002/diff/60001/pkg/compiler/lib/src/diagnostics/messages.dart File pkg/compiler/lib/src/diagnostics/messages.dart (right): https://codereview.chromium.org/2068003002/diff/60001/pkg/compiler/lib/src/diagnostics/messages.dart#newcode890 pkg/compiler/lib/src/diagnostics/messages.dart:890: foo({}) {} The examples in these kinds are ...
4 years, 5 months ago (2016-07-08 07:30:52 UTC) #4
Harry Terkelsen
4 years, 5 months ago (2016-07-08 17:03:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
10691da9f8d938961833580fc21cf4c3c1f6acfd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698