dart2js: allow trailing commas in parameter and argument lists

pkg/compiler/lib/src/diagnostics/messages.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * The messages in this file should meet the following guide lines:
  *
  * 1. The message should be a complete sentence starting with an uppercase
  * letter, and ending with a period.
  *
@@ skipping 168 matching lines @@
   DUPLICATE_LABEL,
   DUPLICATE_SERIALIZED_LIBRARY,
   DUPLICATE_SUPER_INITIALIZER,
   DUPLICATE_TYPE_VARIABLE_NAME,
   DUPLICATED_LIBRARY_NAME,
   DUPLICATED_LIBRARY_RESOURCE,
   DUPLICATED_PART_OF,
   DUPLICATED_RESOURCE,
   EMPTY_CATCH_DECLARATION,
   EMPTY_ENUM_DECLARATION,
+  EMPTY_NAMED_PARAMETER_LIST,
+  EMPTY_OPTIONAL_PARAMETER_LIST,
   EMPTY_HIDE,
+  EMPTY_SHOW,
   EQUAL_MAP_ENTRY_KEY,
-  EMPTY_SHOW,
   EXISTING_DEFINITION,
   EXISTING_LABEL,
   EXPECTED_IDENTIFIER_NOT_RESERVED_WORD,
   EXPERIMENTAL_ASSERT_MESSAGE,
   EXPONENT_MISSING,
   EXPORT_BEFORE_PARTS,
   EXTERNAL_WITH_BODY,
   EXTRA_CATCH_DECLARATION,
   EXTRA_FORMALS,
   EXTRANEOUS_MODIFIER,
@@ skipping 669 matching lines @@
 main() {}"""
             },
             const {
               'main.dart': """
 export 'dart:core' show Foo;
 
 main() {}"""
             },
           ]),
 
+      MessageKind.EMPTY_OPTIONAL_PARAMETER_LIST: const MessageTemplate(
+          MessageKind.EMPTY_OPTIONAL_PARAMETER_LIST,
+          "Optional parameter lists cannot be empty.",
+          howToFix: "Try adding an optional parameter to the list.",
+          examples: const [
+            const {
+              'main.dart': """
+foo({}) {}

[Johnni Winther, 2016/07/08 07:30:52]

The examples in these kinds are swapped: {} should be _NAMED_ and [] should be
_OPTIONAL_

+
+main() {
+  foo();
+}"""
+            }
+          ]),
+
+      MessageKind.EMPTY_NAMED_PARAMETER_LIST: const MessageTemplate(
+          MessageKind.EMPTY_NAMED_PARAMETER_LIST,
+          "Named parameter lists cannot be empty.",
+          howToFix: "Try adding a named parameter to the list.",
+          examples: const [
+            const {
+              'main.dart': """
+foo([]) {}
+
+main() {
+  foo();
+}"""
+            }
+          ]),
+
       MessageKind.NOT_A_TYPE: const MessageTemplate(
           MessageKind.NOT_A_TYPE, "'#{node}' is not a type."),
 
       MessageKind.NOT_A_PREFIX: const MessageTemplate(
           MessageKind.NOT_A_PREFIX, "'#{node}' is not a prefix."),
 
       MessageKind.PREFIX_AS_EXPRESSION: const MessageTemplate(
           MessageKind.PREFIX_AS_EXPRESSION,
           "Library prefix '#{prefix}' is not a valid expression."),
 
@@ skipping 2890 matching lines @@
   static String convertToString(value) {
     if (value is ErrorToken) {
       // Shouldn't happen.
       return value.assertionMessage;
     } else if (value is Token) {
       value = value.value;
     }
     return '$value';
   }
 }