chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc - Issue 2067943004: ARC: Add badge for Chrome hosted Apps if Arc++ is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Issue 2067943004: ARC: Add badge for Chrome hosted Apps if Arc++ is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address xiyuan@'s comment. Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

index ef3a8950effdae1f002810217915e7f0f0c6056d..e8561649e16ac73bb085c75ee84f18b5f529880a 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

@@ -2742,7 +2742,9 @@ TEST_F(ChromeLauncherControllerImplTest, AppPanels) {

InitLauncherControllerWithBrowser();

// App list and Browser shortcut ShelfItems are added.

EXPECT_EQ(2, model_observer_->added());

- EXPECT_EQ(1, model_observer_->changed());

+ // Browser shortcut item changed twice because the browser shortcut needs to

+ // be updated according to the ARC status when attaching profile.

+ EXPECT_EQ(2, model_observer_->changed());

const std::string app_id = extension1_->id();

// app_icon_loader is owned by ChromeLauncherControllerImpl.

@@ -2759,7 +2761,7 @@ TEST_F(ChromeLauncherControllerImplTest, AppPanels) {

app_panel_controller, app_id, ash::STATUS_RUNNING);

int panel_index = model_observer_->last_index();

EXPECT_EQ(3, model_observer_->added());

- EXPECT_EQ(1, model_observer_->changed());

+ EXPECT_EQ(2, model_observer_->changed());

EXPECT_EQ(1, app_icon_loader->fetch_count());

model_observer_->clear_counts();